Support String Catalog symbol generation by adding String Catalogs as both Sources and Resources #8815
Conversation
…talogs as Sources
matthewseaman
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci please test |
|
Will fail in CI until SwiftBuild portion lands via swiftlang/swift-build#582 |
|
Thanks for this change, but would it be possible to add, or enabled, one or more automated tests that would validate the SwiftPM behaviour? |
It would be the same as the Asset Catalog logic on the lines above. Are there existing tests for these code paths somewhere that it would make sense to add to? |
matthewseaman
changed the title
|
@swift-ci please test |
|
@swift-ci test |
|
Added tests in |
| @@ -2216,15 +2222,15 @@ final class PIFBuilderTests: XCTestCase { | |||
| Manifest.createRootManifest( | |||
| displayName: "Foo", | |||
| path: "/Foo", | |||
| toolsVersion: .v5_3, | |||
| toolsVersion: .v5_9, | |||
There was a problem hiding this comment.
Bumped to the first tools version that supports xcstrings at all.
This change adds support for String Catalog symbol generation by ensuring that String Catalogs get added to the Sources build phase in the same way that Asset Catalogs do.
Depends on: swiftlang/swift-build#582