Bug fix for getRange function #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated the commit range to include a fix for issue 10 (#10). |
|
IE fix caused a problem with non-IE, now fixed |
…ocument with the editor
Check if current selection is strikethroughed.
strikethroughSelected was missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getNode method of the Range object iterates over the range ancestor's child nodes with$.each. The $ .each callback function checks if the currently iterating child is in range, and assigns it to a variable child if it is.
There is a variable child declared in the callback function's parent scope, but it never gets assigned anything by because the callback function argument is also called child.
The callback function now assigns to a variable called node, so now getRange works as intended.
Additionally, iteration is now stopped after finding a matching node.