-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Snowflake AI connector, init, model, SP #1298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also remove snowflake-connector-python from requirements.txt? I don't believe it's used anywhere either.
Removed ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry one more thing, can you check the SearchProviders/preload.json There is a snowflake provider in there does it need to be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dnicodemus , no issue with your last question, prealoaded.json is all set as-is. Running smoke tests on the branch now (after merging develop in to update it); if they pass, I'll merge this and let the full suite run.
Branching Reminders
X For core code changes, create a branch off
develop
main
Description
Remove SnowflakeAI connector, connector/init, SP, model
Related Issue(s)
DS-1842
Testing and Validation
Tested other SPs
Type of Change