Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Snowflake AI connector, init, model, SP #1298

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Remove Snowflake AI connector, init, model, SP #1298

merged 4 commits into from
Apr 16, 2024

Conversation

sid-swirl
Copy link
Contributor

@sid-swirl sid-swirl commented Mar 10, 2024

Branching Reminders

X For core code changes, create a branch off develop

  • For product documentation changes, create a branch off main
  • Always name your branch in a way that clearly describes your proposed changes

Description

Remove SnowflakeAI connector, connector/init, SP, model

Related Issue(s)

DS-1842

Testing and Validation

Tested other SPs

Type of Change

  • Bug fix or other non-breaking change that addresses an issue
  • New Feature / Enhancement (non-breaking change that add or improves functionality)
  • New Feature (breaking change that is not backwards compatible and/or alters current functionality)
  • Documentation (change to product documentation or README.md only)

Copy link
Contributor

@dnicodemus dnicodemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove snowflake-connector-python from requirements.txt? I don't believe it's used anywhere either.

@sid-swirl
Copy link
Contributor Author

Removed !

Copy link
Contributor

@dnicodemus dnicodemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry one more thing, can you check the SearchProviders/preload.json There is a snowflake provider in there does it need to be removed?

Copy link
Contributor

@erikspears erikspears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnicodemus , no issue with your last question, prealoaded.json is all set as-is. Running smoke tests on the branch now (after merging develop in to update it); if they pass, I'll merge this and let the full suite run.

@erikspears erikspears merged commit 9b7d831 into develop Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants