Run a search to verify that this is the first PR of the user (#124)

Author: Nyholm

config/services.yaml

@@ -69,6 +69,10 @@ services:
         factory: ['@Github\Client', api]
         arguments: [pullRequest]
 
+    Github\Api\Repo:
+        factory: ['@Github\Client', api]
+        arguments: [repo]
+
     Github\Api\Search:
         factory: ['@Github\Client', api]
         arguments: [search]
@@ -87,6 +91,7 @@ services:
     App\Api\Issue\IssueApi: '@App\Api\Issue\GithubIssueApi'
     App\Api\Label\LabelApi: '@App\Api\Label\GithubLabelApi'
     App\Api\Milestone\MilestoneApi: '@App\Api\Milestone\GithubMilestoneApi'
+    App\Api\PullRequest\PullRequestApi: '@App\Api\PullRequest\GithubPullRequestApi'
     App\Api\Status\StatusApi: '@App\Api\Status\GitHubStatusApi'
 
     App\Service\RepositoryProvider:

config/services_test.yaml

@@ -6,4 +6,5 @@ services:
     App\Api\Issue\IssueApi: '@App\Api\Issue\NullIssueApi'
     App\Api\Label\LabelApi: '@App\Api\Label\StaticLabelApi'
     App\Api\Milestone\MilestoneApi: '@App\Api\Milestone\StaticMilestoneApi'
+    App\Api\PullRequest\PullRequestApi: '@App\Api\PullRequest\GithubPullRequestApi'
     App\Api\Status\StatusApi: '@App\Api\Status\NullStatusApi'

src/Api/PullRequest/GithubPullRequestApi.php

@@ -5,6 +5,7 @@
 use App\Model\Repository;
 use Github\Api\PullRequest;
 use Github\Api\Repo;
+use Github\Api\Search;
 
 /**
  * @author Tobias Nyholm <tobias.nyholm@gmail.com>
@@ -15,14 +16,16 @@ class GithubPullRequestApi implements PullRequestApi
      * @var Repo
      */
     private $github;
-    private $botUsername;
     private $pullRequest;
+    private $search;
+    private $botUsername;
 
-    public function __construct(Repo $github, PullRequest $pullRequest, string $botUsername)
+    public function __construct(Repo $github, PullRequest $pullRequest, Search $search, string $botUsername)
     {
         $this->github = $github;
-        $this->botUsername = $botUsername;
         $this->pullRequest = $pullRequest;
+        $this->search = $search;
+        $this->botUsername = $botUsername;
     }
 
     public function show(Repository $repository, $number): array
@@ -41,4 +44,11 @@ public function findReviewer(Repository $repository, $number, string $type)
             'type' => $type,
         ]);
     }
+
+    public function getAuthorCount(Repository $repository, string $author): int
+    {
+        $result = $this->search->issues(sprintf('is:pr repo:%s author:%s', $repository->getFullName(), $author));
+
+        return $result['total_count'];
+    }
 }

src/Api/PullRequest/NullPullRequestApi.php

@@ -19,4 +19,9 @@ public function show(Repository $repository, $number): array
     public function findReviewer(Repository $repository, $number, string $type)
     {
     }
+
+    public function getAuthorCount(Repository $repository, string $author): int
+    {
+        return 1;
+    }
 }

src/Api/PullRequest/PullRequestApi.php

@@ -17,4 +17,6 @@ interface PullRequestApi
     public function show(Repository $repository, $number): array;
 
     public function findReviewer(Repository $repository, $number, string $type);
+
+    public function getAuthorCount(Repository $repository, string $author): int;
 }

src/Subscriber/WelcomeFirstTimeContributorSubscriber.php

@@ -3,6 +3,7 @@
 namespace App\Subscriber;
 
 use App\Api\Issue\IssueApi;
+use App\Api\PullRequest\PullRequestApi;
 use App\Event\GitHubEvent;
 use App\GitHubEvents;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
@@ -13,10 +14,12 @@
 class WelcomeFirstTimeContributorSubscriber implements EventSubscriberInterface
 {
     private $commentsApi;
+    private $pullRequestApi;
 
-    public function __construct(IssueApi $commentsApi)
+    public function __construct(IssueApi $commentsApi, PullRequestApi $pullRequestApi)
     {
         $this->commentsApi = $commentsApi;
+        $this->pullRequestApi = $pullRequestApi;
     }
 
     public function onPullRequest(GitHubEvent $event)
@@ -32,6 +35,11 @@ public function onPullRequest(GitHubEvent $event)
         }
 
         $repository = $event->getRepository();
+        if ($this->pullRequestApi->getAuthorCount($repository, $data['sender']['login']) > 1) {
+            // This users has made pull requests before
+            return;
+        }
+
         $pullRequestNumber = $data['pull_request']['number'];
         $defaultBranch = $data['repository']['default_branch'];
         $this->commentsApi->commentOnIssue($repository, $pullRequestNumber, <<<TXT