Fix potential TypeError from accessing null ref in React 19.1.0 (#1517)

Author: szhsin

dist/cjs/components/MenuList.cjs

@@ -123,6 +123,9 @@ const MenuList = ({
     if (e.target === e.currentTarget) submenuCtx$1.off();
   };
   const handlePosition = react.useCallback(noOverflowCheck => {
+    const menuElt = menuRef.current;
+    const containerElt = containerRef.current;
+    if (!menuElt || !containerElt) return;
     const anchorRect = anchorRef ? anchorRef.current?.getBoundingClientRect() : anchorPoint ? {
       left: anchorPoint.x,
       right: anchorPoint.x,
@@ -140,7 +143,7 @@ const MenuList = ({
     if (!scrollNodes.menu) {
       scrollNodes.menu = (boundingBoxRef ? boundingBoxRef.current : utils.getScrollAncestor(rootMenuRef.current)) || window;
     }
-    const positionHelpers = getPositionHelpers.getPositionHelpers(containerRef, menuRef, scrollNodes.menu, boundingBoxPadding);
+    const positionHelpers = getPositionHelpers.getPositionHelpers(containerElt, menuElt, scrollNodes.menu, boundingBoxPadding);
     let {
       arrowX,
       arrowY,

dist/cjs/positionUtils/getPositionHelpers.cjs

@@ -3,9 +3,9 @@
 var getNormalizedClientRect = require('./getNormalizedClientRect.cjs');
 var utils = require('../utils/utils.cjs');
 
-const getPositionHelpers = (containerRef, menuRef, menuScroll, boundingBoxPadding) => {
-  const menuRect = getNormalizedClientRect.getNormalizedClientRect(menuRef.current);
-  const containerRect = containerRef.current.getBoundingClientRect();
+const getPositionHelpers = (containerElt, menuElt, menuScroll, boundingBoxPadding) => {
+  const menuRect = getNormalizedClientRect.getNormalizedClientRect(menuElt);
+  const containerRect = containerElt.getBoundingClientRect();
   const boundingRect = menuScroll === window ? {
     left: 0,
     top: 0,

dist/esm/components/MenuList.mjs

@@ -121,6 +121,9 @@ const MenuList = ({
     if (e.target === e.currentTarget) submenuCtx.off();
   };
   const handlePosition = useCallback(noOverflowCheck => {
+    const menuElt = menuRef.current;
+    const containerElt = containerRef.current;
+    if (!menuElt || !containerElt) return;
     const anchorRect = anchorRef ? anchorRef.current?.getBoundingClientRect() : anchorPoint ? {
       left: anchorPoint.x,
       right: anchorPoint.x,
@@ -138,7 +141,7 @@ const MenuList = ({
     if (!scrollNodes.menu) {
       scrollNodes.menu = (boundingBoxRef ? boundingBoxRef.current : getScrollAncestor(rootMenuRef.current)) || window;
     }
-    const positionHelpers = getPositionHelpers(containerRef, menuRef, scrollNodes.menu, boundingBoxPadding);
+    const positionHelpers = getPositionHelpers(containerElt, menuElt, scrollNodes.menu, boundingBoxPadding);
     let {
       arrowX,
       arrowY,

dist/esm/positionUtils/getPositionHelpers.mjs

@@ -1,9 +1,9 @@
 import { getNormalizedClientRect } from './getNormalizedClientRect.mjs';
 import { parsePadding } from '../utils/utils.mjs';
 
-const getPositionHelpers = (containerRef, menuRef, menuScroll, boundingBoxPadding) => {
-  const menuRect = getNormalizedClientRect(menuRef.current);
-  const containerRect = containerRef.current.getBoundingClientRect();
+const getPositionHelpers = (containerElt, menuElt, menuScroll, boundingBoxPadding) => {
+  const menuRect = getNormalizedClientRect(menuElt);
+  const containerRect = containerElt.getBoundingClientRect();
   const boundingRect = menuScroll === window ? {
     left: 0,
     top: 0,

src/components/MenuList.js

@@ -145,6 +145,10 @@ export const MenuList = ({
 
   const handlePosition = useCallback(
     (noOverflowCheck) => {
+      const menuElt = menuRef.current;
+      const containerElt = containerRef.current;
+      if (!menuElt || !containerElt) return;
+
       const anchorRect = anchorRef
         ? anchorRef.current?.getBoundingClientRect()
         : anchorPoint
@@ -174,8 +178,8 @@ export const MenuList = ({
       }
 
       const positionHelpers = getPositionHelpers(
-        containerRef,
-        menuRef,
+        containerElt,
+        menuElt,
         scrollNodes.menu,
         boundingBoxPadding
       );

src/positionUtils/getPositionHelpers.js

@@ -1,9 +1,9 @@
 import { parsePadding } from '../utils';
 import { getNormalizedClientRect } from './getNormalizedClientRect';
 
-export const getPositionHelpers = (containerRef, menuRef, menuScroll, boundingBoxPadding) => {
-  const menuRect = getNormalizedClientRect(menuRef.current);
-  const containerRect = containerRef.current.getBoundingClientRect();
+export const getPositionHelpers = (containerElt, menuElt, menuScroll, boundingBoxPadding) => {
+  const menuRect = getNormalizedClientRect(menuElt);
+  const containerRect = containerElt.getBoundingClientRect();
   const boundingRect =
     menuScroll === window
       ? {