Skip to content

Fix JettonBurnNotification and related things in benchmarks #2734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
novusnota opened this issue Apr 11, 2025 · 1 comment · May be fixed by #2735
Open

Fix JettonBurnNotification and related things in benchmarks #2734

novusnota opened this issue Apr 11, 2025 · 1 comment · May be fixed by #2735
Assignees
@Kaladin13
Labels
kind: bug Something isn't working or isn't right scope: stdlib The Tact standard library (src/stdlib)
Milestone
v1.8.0

Comments

@novusnota
Copy link
Member

novusnota commented Apr 11, 2025 •
edited
Loading

Currently, addresses in JettonBurn and JettonBurnNotification are represented as Address whereas they should be Address? to support the MsgAddress from the Jetton standards TL-B.

This fix is needed for #2509.
@novusnota novusnota added kind: bug Something isn't working or isn't right scope: stdlib The Tact standard library (src/stdlib) labels Apr 11, 2025
@novusnota novusnota added this to the v1.6.6 milestone Apr 11, 2025
@novusnota novusnota mentioned this issue Apr 11, 2025
Draft
@novusnota novusnota changed the title Fix JettonBurnNotification and related in benchmarks Fix JettonBurnNotification and related things in benchmarks Apr 11, 2025
@Kaladin13 Kaladin13 linked a pull request Apr 11, 2025 that will close this issue
Draft
@anton-trunov
Copy link
Member

What is the exact problem here? It's not clear what this issue is about

@anton-trunov anton-trunov removed this from the v1.6.6 milestone Apr 15, 2025
@novusnota novusnota added this to the v1.7.0 milestone Apr 16, 2025
@anton-trunov anton-trunov modified the milestones: v1.6.7, v1.7.0 Apr 22, 2025
@novusnota novusnota modified the milestones: v1.7.0, v1.8.0 Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kaladin13 Kaladin13

Labels
kind: bug Something isn't working or isn't right scope: stdlib The Tact standard library (src/stdlib)
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging a pull request may close this issue.

fix(benches): tlb types for jettons tact-lang/tact
3 participants
@anton-trunov @novusnota @Kaladin13