Skip to content

Constant evaluation is not used widely during compilation #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Gusarich opened this issue May 17, 2024 · 0 comments · Fixed by #352
Closed

Constant evaluation is not used widely during compilation #345

Gusarich opened this issue May 17, 2024 · 0 comments · Fixed by #352
Assignees
@Gusarich
Labels
scope: partial-eval The constant and partial evaluation optimization mechanisms (src/optimizer/constEval.ts)
Milestone
v1.3.1

Comments

@Gusarich
Copy link
Member

Turns out that the reason behind both #327 and #339 is that constant evaluation in compiler works not with all values actually. It's only being called in certain cases, such as static calls of globally defined functions.
We should change this behavior.
@Gusarich Gusarich self-assigned this May 23, 2024
@Gusarich Gusarich mentioned this issue May 23, 2024
Merged
4 tasks
@Gusarich Gusarich added this to the v1.3.1 milestone May 23, 2024
@verytactical verytactical added scope: partial-eval The constant and partial evaluation optimization mechanisms (src/optimizer/constEval.ts) and removed scope: const-eval labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gusarich Gusarich

Labels
scope: partial-eval The constant and partial evaluation optimization mechanisms (src/optimizer/constEval.ts)
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging a pull request may close this issue.

Fix const eval Gusarich/tact
2 participants
@Gusarich @verytactical