Skip to content

docs: add CONTRIBUTING.md #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

i582
Copy link
Member

@i582 i582 commented Dec 28, 2024

Fixes #35

@anton-trunov
Copy link
Member

Awesome! Thanks for taking care of this. I haven't read the content yet. Just a minor suggestion: let's add a link to the guide to README.md to increase its visibility

@i582
Copy link
Member Author

i582 commented Jan 14, 2025

@novusnota can you check this PR? :)

Comment on lines +18 to +42
### Reporting Issues

- Include code snippets and error messages
- Include as much detail as possible
- Include steps to reproduce the issue
- Include the version of tree-sitter you're using
- Use code blocks for error messages and logs

### Making Changes

1. Fork the repository
2. Create a new branch for your changes
3. Make your changes
4. Write or update tests as needed
5. Ensure all tests pass
6. Format the code using `npm run fmt`
7. Submit a pull request

### Pull Request Process

1. Update the README.md if needed
2. Follow the existing code style
3. Include a clear description of your changes
4. Link any related issues using keywords (e.g., "Fixes #123")
5. Wait for review from maintainers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably removed this altogether or moved it somewhere to highlight the dev setup and the overall structure of the project which follows below

@novusnota
Copy link
Member

novusnota commented Mar 26, 2025

Let's close this for now and revisit it later. We need to include points about:

  1. Upstream repositories that use this parser: https://github.com/nvim-treesitter/
  2. Review policies: currently I oversee everything, but a spare pair of eyes could be helpful
  3. BDFL-light approach :)

Thank you @i582 for the initial progress on this! ❤️

@novusnota novusnota closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add contributing guide
3 participants