android/ui: show count of Mullvad countries, also fix navigation-rela… #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
force-pushed
the
ox/mullvad_country_count
branch
from
8d949c2 to
45cb242
Compare
oxtoacart
commented
Apr 9, 2024
| @@ -106,7 +105,7 @@ class MainActivity : ComponentActivity() { | |||
|
|
|||
| setContent { | |||
| AppTheme { | |||
| val navController = rememberNavController() | |||
| navController = rememberNavController() | |||
There was a problem hiding this comment.
This is a drive-by fix errors like
kotlin.UninitializedPropertyAccessException: lateinit property navController has not been initialized
at com.tailscale.ipn.MainActivity.onNewIntent(MainActivity.kt:248)
oxtoacart
commented
Apr 9, 2024
| } | ||
| composable("runExitNode") { RunExitNodeView(exitNodePickerNav) } | ||
| } | ||
| composable("exitNodes") { ExitNodePicker(exitNodePickerNav) } |
There was a problem hiding this comment.
This is a drive-by fix to broken back-navigation from Mullvad to exit nodes
kari-ts
approved these changes
Apr 9, 2024
…ted crash when adding new account Updates tailscale/corp#18202 Signed-off-by: Percy Wegmann <percy@tailscale.com>
oxtoacart
force-pushed
the
ox/mullvad_country_count
branch
from
45cb242 to
7982b9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ted crash when adding new account
Updates tailscale/corp#18202