ui: reintroduce dark mode theme #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agottardo
force-pushed
the
angott/reintroduce-dark-mode
branch
2 times, most recently
from
001a2f3 to
b353380
Compare
agottardo
force-pushed
the
angott/reintroduce-dark-mode
branch
from
b353380 to
9d5ee2f
Compare
Fixes tailscale/corp#19137
Reintroduces the dark mode theme for the app, using mockups on Figma.
Signed-off-by: Andrea Gottardo <andrea@gottardo.me>
agottardo
force-pushed
the
angott/reintroduce-dark-mode
branch
from
9d5ee2f to
8c2b6ec
Compare
oxtoacart
reviewed
Apr 11, 2024
| fun TailscaleLogoView(animated: Boolean = false, modifier: Modifier) { | ||
| fun TailscaleLogoView( | ||
| animated: Boolean = false, | ||
| usesOnBackgroundColors: Boolean = false, |
There was a problem hiding this comment.
Why make this a parameter instead of just checking isSystemInDarkTheme()?
There was a problem hiding this comment.
The colours we use to draw each dot in the logo are different depending on whether you're drawing the logo on top of a generic app surface (such as for a progress indicator, or the welcome view), or over MaterialTheme.colorScheme.logoBackground, which you're going to use to draw the app icon (we use that in the about view). See what the iOS implementation does with the logoStyle enum parameter.
oxtoacart
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Code LGTM and visually things look in order. I'll defer to @sonovawolf for final design review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.