ReplayGain: make sure volume doesn't exceed 1.0

[sentriz]

sometimes the clamp will result in this.audio.volume being slightly >1 which throws an exception since it must be in the range 0-1 https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/volume

i think this happens if the peak volume calcuation is slightly off in the tags. since most of the time when when this happens for me it's trying to set it to soemthing like 1.012323

[tamland]

I think you should fix replayGainFactor() function to ensure it never returns a value greater than 1. The original from and to parameters will always be in the 0..1 range

[sentriz]

I'm not sure we want to clamp the replaingain factor. sometimes it says that we want to boost the signal if it's too quiet. that's part of the spec

looking at another implementaion it looks like the browser has a GainNode which can be >1 while still only letting the user's volume property be max at one

looks like that would be a good usecase to seperate user volume and calculated gain. maybe the fading functionality could use that too. wdyt?

[tamland]

It's interesting. I'm not sure how much work that will be as it still has to support buffering, playback speed and more

[tamland]

Merging this in the meantime.

Started to implement the web audio solution here: https://github.com/tamland/airsonic-refix/tree/web-audio Still have some minor fade bugs i haven't figured out yet, but other than that it works.