Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from pnpm back to yarn classic #1

Open
taronaeo opened this issue Apr 15, 2024 · 2 comments
Open

Switch from pnpm back to yarn classic #1

taronaeo opened this issue Apr 15, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@taronaeo
Copy link
Owner

Everything works well when you do not have mono repo packages linking to one another. But once you start linking (e.g., @riva/shared package with @riva/portal), everything breaks down and fails to deploy.

The decision to switch to pnpm was primarily to be compatible with isolate-package which has since been tested to be running smoothly with yarn modern and classic as well.

Action: Discontinue usage of pnpm and swap back to yarn classic until Firebase starts supporting other package managers out of the box

@taronaeo taronaeo added the bug Something isn't working label Apr 15, 2024
@taronaeo taronaeo self-assigned this Apr 15, 2024
@taronaeo
Copy link
Owner Author

As of right now, @riva/shared is declared as a dev dependency in @riva/portal (commit 2940db9) and that is not right.

The reason this works right now is because the shared code is mainly TypeScript models that get compiled into nothing. But once we factor in constant variables, everything will break.

@taronaeo
Copy link
Owner Author

An alternative solution is to use Cloudflare Worker sites which effectively works the same as Firebase Hosting for webframeworks. But it is currently un-tested and we won't know if it completely solves the problem or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant