-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
은행 창구 관리 앱 [STEP 4] Jane, Sajae #98
Open
jane1choi
wants to merge
31
commits into
tasty-code:d_Sajae
Choose a base branch
from
suojae:feat/step4
base: d_Sajae
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
134cd64
config: Main 스토리보드 삭제 및 루트 뷰 설정
jane1choi bdbc81c
feat: Then 프로토콜 정의
jane1choi ce7ba43
feat: UIStackView extension 추가
jane1choi d6781fd
feat: BankViewController 기본 UI 구성
jane1choi 2fdd92b
chore: 시작 뷰컨트롤러 변경
jane1choi b507518
chore: ViewController 파일 이름 수정
jane1choi b25f624
feat: Client 모델 추가
suojae 72e834b
feat: BankTask 모델 추가
suojae d1ced4c
feat: ViewModel 프로토콜 정의
jane1choi b4b5466
feat: UITableViewCell+ 파일 추가
jane1choi 673aa24
feat: 커스텀 tableViewCell 정의
jane1choi c547859
feat: 더미데이터를 활용한 테이블 뷰 UI 구성
jane1choi 33b3c4d
feat: TimerHandler 추가
suojae ddadc9f
chore: TimeUnit 구조체 추가 및 적용
suojae b60a853
config: 프로젝트 파일 폴더링
jane1choi e9686ad
feat: Observable 타입 정의
jane1choi 9b1cdd9
feat: BankRepository 정의
jane1choi ab84765
feat: BankViewModel 추가 및 폴더링
jane1choi 90b816d
feat: 고객 10명 추가 기능 구현
jane1choi f614f29
feat: 의존성 주입 코드 추가
jane1choi f6e4a0e
chore: BankTimer 네이밍 변경
suojae 965cd93
chore: Observable 이용한 Timer 데이터 바인딩
suojae f4fb31f
feat: reset버튼 액션 추가
suojae e3af0ee
chore: 변수명에서 get 제거
suojae bb1d7fa
feat: 셀 재사용에 대비한 초기화 및 UI 설정 코드 추가
jane1choi 41c2dd3
feat: 은행 업무 처리 기능 구현
jane1choi 2e69567
fix: 순환 참조 문제 해결
jane1choi af19f16
chore: life cycle 코드 위치 수정 및 마크 구문 추가
jane1choi 57066b4
chore: 메서드 네이밍 수정
jane1choi 942a16b
feat: 업무중 테이블 뷰 UI 연결 및 마크 구문 추가
jane1choi 27084bc
chore: 자잘한 코드 수정
jane1choi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,7 @@ final class BankViewModel { | |
} | ||
|
||
func fetchTimeString() { | ||
timer.getTimeString = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. timeString 이란 이름도 조금 모호한 것 같아요 ! |
||
timer.timeString = { | ||
self.timeString.value = $0 | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delegate패턴으로 바꾼다면 어떤식으로 바뀔까요 ?