IP6NDSolicitor: Make batch compatible #408
Open
+50
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrybowski
approved these changes
Feb 20, 2025
Comment on lines
+292
to
+294
| Packet* p = handle_ip6(p); | ||
| if (p) | ||
| output_push(0, p); |
There was a problem hiding this comment.
Segfault here because of variable capture.
Packet* out = handle_ip6(p);
if (out)
output_push(0, out);| return q; | ||
| } | ||
| }; | ||
| EXECUTE_FOR_EACH_PACKET_DROPPABLE(fnt, batch); |
There was a problem hiding this comment.
There is a missing argument in the macro call.
EXECUTE_FOR_EACH_PACKET_DROPPABLE(fnt, batch, [](Packet*){});| } | ||
|
|
||
| /* | ||
| * Got an Neighborhood Advertisement (response to N. Solicitation Message) | ||
| * Update our NDEntry table. | ||
| * If there was a packet waiting to be sent, return it. | ||
| */ | ||
| void | ||
| Packet* | ||
| IP6NDSolicitor::handle_response(Packet *p) | ||
| { | ||
| if (p->length() < sizeof(click_ether) + sizeof(click_ip6) + sizeof(click_nd_sol)) |
There was a problem hiding this comment.
The following return should return 0. Same comment for the return at L270.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.