-
Notifications
You must be signed in to change notification settings - Fork 125
Improper relative path parsing, URLs parsed as Markdown #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
listx
pushed a commit
to listx/prow
that referenced
this issue
Oct 26, 2022
Unfortunately we cannot use the much prettier-looking https://github.com/tcort/markdown-link-check tool because it cannot handle relative links to other Markdown files. For some related discussion, see tcort/markdown-link-check#215. So instead we just use [htmltest](https://github.com/wjdp/htmltest). This isn't included in CI yet because we're using it to locally check for broken links as part of the update of the "Legacy Snapshot" folder. Later when things stabilize, we can consider adding this to CI (although adding it CI might be not a great idea because of expected flakiness, unless we add additional instrumentation around this).
cjwagner
pushed a commit
to cjwagner/prow
that referenced
this issue
Mar 22, 2024
Unfortunately we cannot use the much prettier-looking https://github.com/tcort/markdown-link-check tool because it cannot handle relative links to other Markdown files. For some related discussion, see tcort/markdown-link-check#215. So instead we just use [htmltest](https://github.com/wjdp/htmltest). This isn't included in CI yet because we're using it to locally check for broken links as part of the update of the "Legacy Snapshot" folder. Later when things stabilize, we can consider adding this to CI (although adding it CI might be not a great idea because of expected flakiness, unless we add additional instrumentation around this).
This issue has been marked as stale because it has been open 60 days with no activity. It will be closed in 30 days unless the stale label is removed or someone adds a comment. |
Bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The URLs provided are:
The link checker shows these as an error:
As you can see, the backslash
\
is gone. I wondered if this was just a rendering issue in the log. It was not. If I change the URLs to this, they pass.This escapes (in Markdown) that backslash and now the URLs pass. This should not be necessary as URLs should not be parsed as Markdown in this way.
If I write the original paths not using a Code block in this issue description, you can see they render the same as shown in the log. This leads me to believe they are parsed improperly as Markdown.
The text was updated successfully, but these errors were encountered: