Skip to content

Improper relative path parsing, URLs parsed as Markdown #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MiYanni opened this issue Jul 16, 2022 · 2 comments
Open

Improper relative path parsing, URLs parsed as Markdown #215

MiYanni opened this issue Jul 16, 2022 · 2 comments

Comments

@MiYanni
Copy link

MiYanni commented Jul 16, 2022

The URLs provided are:

..\..\build\import\Versions.props
..\..\version.json

The link checker shows these as an error:

FILE: ./.github/ISSUE_TEMPLATE/branch-checklist.md
[✖] ....\build\import\Versions.props
[✖] ....\version.json

ERROR: 2 dead links found!
[✖] ....\build\import\Versions.props → Status: 400
[✖] ....\version.json → Status: 400

As you can see, the backslash \ is gone. I wondered if this was just a rendering issue in the log. It was not. If I change the URLs to this, they pass.

..\\..\build\import\Versions.props
..\\..\version.json

This escapes (in Markdown) that backslash and now the URLs pass. This should not be necessary as URLs should not be parsed as Markdown in this way.

If I write the original paths not using a Code block in this issue description, you can see they render the same as shown in the log. This leads me to believe they are parsed improperly as Markdown.

....\build\import\Versions.props
....\version.json

listx pushed a commit to listx/prow that referenced this issue Oct 26, 2022
Unfortunately we cannot use the much prettier-looking
https://github.com/tcort/markdown-link-check tool because it cannot
handle relative links to other Markdown files. For some related
discussion, see tcort/markdown-link-check#215.

So instead we just use [htmltest](https://github.com/wjdp/htmltest).
This isn't included in CI yet because we're using it to locally check
for broken links as part of the update of the "Legacy Snapshot" folder.
Later when things stabilize, we can consider adding this to CI (although
adding it CI might be not a great idea because of expected flakiness,
unless we add additional instrumentation around this).
cjwagner pushed a commit to cjwagner/prow that referenced this issue Mar 22, 2024
Unfortunately we cannot use the much prettier-looking
https://github.com/tcort/markdown-link-check tool because it cannot
handle relative links to other Markdown files. For some related
discussion, see tcort/markdown-link-check#215.

So instead we just use [htmltest](https://github.com/wjdp/htmltest).
This isn't included in CI yet because we're using it to locally check
for broken links as part of the update of the "Legacy Snapshot" folder.
Later when things stabilize, we can consider adding this to CI (although
adding it CI might be not a great idea because of expected flakiness,
unless we add additional instrumentation around this).
Copy link

This issue has been marked as stale because it has been open 60 days with no activity. It will be closed in 30 days unless the stale label is removed or someone adds a comment.

@github-actions github-actions bot added the Stale label Apr 12, 2025
@MiYanni
Copy link
Author

MiYanni commented Apr 15, 2025

Bump.

@github-actions github-actions bot removed the Stale label Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant