Skip to content

gaurav-nelson/github-action-markdown-link-check is no longer maintained #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WillGibson opened this issue Apr 9, 2025 · 10 comments
Open

Comments

@WillGibson
Copy link
Collaborator

WillGibson commented Apr 9, 2025

@tcort @smainil @BaseMax

Options include:

  • Fork it and maintain a tcort action to go with the checker
  • Ask @gaurav-nelson if they are happy for us to maintain it or transfer ownership
  • Evaluate Linkspector and consider whether we want to continue to support markdown-link-check or provide instructions for moving over.

Based on my initial tests the third one is not an option just yet, but it may be worth considering the benefits of joining forces on a single tool.

Thoughts?

@smainil
Copy link
Collaborator

smainil commented Apr 10, 2025

If we want people to continue using markdown-link-check, I think we should provide our own github action.

I don't know if linkspector is better or not / what's the differences

@WillGibson
Copy link
Collaborator Author

Let's fork it.

Makes sense for it to live with the other repositories I think.

@tcort, please could you fork gaurav-nelson/github-action-markdown-link-check and add the rest of us as maintainers and I'll take it from there.

@tcort
Copy link
Owner

tcort commented Apr 13, 2025

Let's fork it.

Makes sense for it to live with the other repositories I think.

@tcort, please could you fork gaurav-nelson/github-action-markdown-link-check and add the rest of us as maintainers and I'll take it from there.

Done! https://github.com/tcort/github-action-markdown-link-check

@gaurav-nelson
Copy link
Contributor

I don't have any issues. I'll add the link to this action in gaurav-nelson/github-action-markdown-link-check and archive that repository. Thank you @tcort @WillGibson @smainil

@WillGibson
Copy link
Collaborator Author

@tcort Can I get access to the settings for the new repository to set up branch protection, default to squash merge etc.?

@WillGibson
Copy link
Collaborator Author

I think I will want to detach the fork too, so that pull requests don't default to being made to @gaurav-nelson's repository.

@gjermundgaraba
Copy link
Contributor

FYI: the new github action was tagged with 1.1.0 instead of v1.1.0, so the docs are broken (they say to use tcort/github-action-markdown-link-check@v1, but it would have to be tcort/github-action-markdown-link-check@1 to be equivalent. I suggest re-releasing as v1.1.0 to keep consistent with how most github actions does it.

(I wrote this here, because issues are not enabled on the github action repo)

@BaseMax
Copy link
Collaborator

BaseMax commented May 12, 2025

Thanks @gjermundgaraba for checking the text and your recent PR.

@WillGibson
Copy link
Collaborator Author

Good point @gjermundgaraba. I will do a new release.

@WillGibson
Copy link
Collaborator Author

Done. Released as v1.1.0 and v1, Readme updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants