Skip to content

Commit 09763da

Browse files
WEBRTC-2733: SocketObserver onError method signature change (#563)
* WEBRTC-2733: Update SocketObserver onError method signature to include errorCode parameter - Updated abstract onError method to accept errorCode: Int? as first parameter - Updated onChanged method to pass value.errorCode to onError callback - Updated MainActivity sample implementation to handle new errorCode parameter - Maintains backward compatibility by making errorCode nullable * WEBRTC-2733: Update documentation to reflect new onError method signature - Updated README.md example to include errorCode parameter - Updated docs-markdown/classes/TelnyxClient.md to show new method signature - Updated docs-markdown/classes/Call.md example to include errorCode parameter - Added comments explaining the errorCode parameter purpose --------- Co-authored-by: openhands <openhands@all-hands.dev>
1 parent 9a40273 commit 09763da

File tree

5 files changed

+10
-8
lines changed

5 files changed

+10
-8
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,9 @@ We can then use this method to create a listener that listens for an invitation
197197
// Show loading dialog
198198
}
199199

200-
override fun onError(message: String?) {
200+
override fun onError(errorCode: Int?, message: String?) {
201201
// Handle errors - Update UI or Navigate to new screen, etc.
202+
// errorCode provides additional context about the error type
202203
}
203204

204205
override fun onSocketDisconnect() {

docs-markdown/classes/Call.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,9 @@ We can then use this method to create a listener that listens for an invitation
6565
// Show loading dialog
6666
}
6767

68-
override fun onError(message: String?) {
68+
override fun onError(errorCode: Int?, message: String?) {
6969
// Handle errors - Update UI or Navigate to new screen, etc.
70+
// errorCode provides additional context about the error type
7071
}
7172

7273
override fun onSocketDisconnect() {

docs-markdown/classes/TelnyxClient.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,15 +152,15 @@ abstract class SocketObserver<T> : Observer<SocketResponse<T>> {
152152
abstract fun onConnectionEstablished()
153153
abstract fun onMessageReceived(data: T?)
154154
abstract fun onLoading()
155-
abstract fun onError(message: String?)
155+
abstract fun onError(errorCode: Int?, message: String?)
156156
abstract fun onSocketDisconnect()
157157

158158
override fun onChanged(value: SocketResponse<T>) {
159159
when (value.status) {
160160
SocketStatus.ESTABLISHED -> onConnectionEstablished()
161161
SocketStatus.MESSAGERECEIVED -> onMessageReceived(value.data)
162162
SocketStatus.LOADING -> onLoading()
163-
SocketStatus.ERROR -> onError(value.errorMessage)
163+
SocketStatus.ERROR -> onError(value.errorCode, value.errorMessage)
164164
SocketStatus.DISCONNECT -> onSocketDisconnect()
165165
}
166166
}

samples/connection_service_app/src/main/java/com/telnyx/webrtc/sdk/ui/MainActivity.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,8 +343,8 @@ class MainActivity : AppCompatActivity() {
343343
Timber.i("Loading...")
344344
}
345345

346-
override fun onError(message: String?) {
347-
Timber.e("onError: %s", message)
346+
override fun onError(errorCode: Int?, message: String?) {
347+
Timber.e("onError: errorCode=%s, message=%s", errorCode, message)
348348
Toast.makeText(
349349
this@MainActivity,
350350
message ?: "Socket Connection Error",

telnyx_rtc/src/main/java/com/telnyx/webrtc/sdk/verto/receive/SocketObserver.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ abstract class SocketObserver<T> : Observer<SocketResponse<T>> {
1212
abstract fun onConnectionEstablished()
1313
abstract fun onMessageReceived(data: T?)
1414
abstract fun onLoading()
15-
abstract fun onError(message: String?)
15+
abstract fun onError(errorCode: Int?, message: String?)
1616
abstract fun onSocketDisconnect()
1717

1818
override fun onChanged(value: SocketResponse<T>) {
1919
when (value.status) {
2020
SocketStatus.ESTABLISHED -> onConnectionEstablished()
2121
SocketStatus.MESSAGERECEIVED -> onMessageReceived(value.data)
2222
SocketStatus.LOADING -> onLoading()
23-
SocketStatus.ERROR -> onError(value.errorMessage)
23+
SocketStatus.ERROR -> onError(value.errorCode, value.errorMessage)
2424
SocketStatus.DISCONNECT -> onSocketDisconnect()
2525
}
2626
}

0 commit comments

Comments
 (0)