WEBRTC-2732: Fix network error dialog shown after user disconnection #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add isIntentionalDisconnect flag to track user-initiated disconnects - Suppress error dialogs when user manually clicks disconnect button - Reset flag on successful login and after disconnect completes - Prevents confusing error messages when user intentionally disconnects
Oliver-Zimmerman
requested changes
May 30, 2025
| @@ -1929,6 +1932,9 @@ class TelnyxClient( | |||
| invalidateGatewayResponseTimer() | |||
| resetGatewayCounters() | |||
| unregisterNetworkCallback() | |||
| socket.destroy() | |||
|
|
|||
| Handler(Looper.getMainLooper()).postDelayed(Runnable { | |||
There was a problem hiding this comment.
I'm not sure how I feel about this.
we onDisconnect manually sometimes to destroy the socket to ensure we get push notifications. I don't know about adding an artificial delay.
On the other hand, 500ms isn't huge in the grand scheme of things. I would prefer to try solve this on the client side somehow though...
There was a problem hiding this comment.
Sure, we can fix this at the telnyx_common side by adding a variable, which will be set to true when the disconnection action comes from the user. In this case we can change handling error to handling disconnection. However I'm not sure which solution is less elegant...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where network error dialogs were shown after user intentionally disconnects from WebRTC session.
Problem
When users clicked the 'Disconnect' button, they would sometimes see error dialogs appearing after the intentional disconnect. This created confusion as users expected a clean disconnect without error messages.
Solution
isIntentionalDisconnectflag to track when disconnection is user-initiatedhandleError()method to suppress error dialogs when disconnect is intentionaldisconnect()method when user manually disconnectsChanges
isIntentionalDisconnectdisconnect()methodhandleError()to suppress dialogshandleLogin()andhandleDisconnect()Testing
Related