Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

Commit

Permalink
Fix flag manager log name collisions
Browse files Browse the repository at this point in the history
  • Loading branch information
jonahsnider committed Feb 21, 2024
1 parent f67f2bf commit 6e8cd9b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/main/java/frc/robot/note_manager/NoteManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import org.littletonrobotics.junction.Logger;

public class NoteManager extends LifecycleSubsystem {
private final FlagManager<NoteFlag> flags = new FlagManager<>(NoteFlag.class);
private final FlagManager<NoteFlag> flags = new FlagManager<>("NoteManager", NoteFlag.class);

public final QueuerSubsystem queuer;
public final IntakeSubsystem intake;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/frc/robot/robot_manager/RobotManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public class RobotManager extends LifecycleSubsystem {
// really care whether we're homed.
private RobotState state = RobotState.IDLE_NO_GP;

private final FlagManager<RobotFlag> flags = new FlagManager<>(RobotFlag.class);
private final FlagManager<RobotFlag> flags = new FlagManager<>("RobotManager", RobotFlag.class);

public RobotManager(
WristSubsystem wrist,
Expand Down
10 changes: 5 additions & 5 deletions src/main/java/frc/robot/util/FlagManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,20 @@
import org.littletonrobotics.junction.Logger;

public class FlagManager<T extends Enum<T>> {
private final Class<T> flag;
private final String loggerCategory;
private final EnumSet<T> allMembers;

private final Set<T> checked;

public FlagManager(Class<T> flag) {
this.flag = flag;
public FlagManager(String loggerCategory, Class<T> flag) {
this.loggerCategory = loggerCategory;
this.allMembers = EnumSet.allOf(flag);
this.checked = EnumSet.noneOf(flag);
}

public void log() {
for (T flag : allMembers) {
Logger.recordOutput("RobotManager/Flags/" + flag.toString(), checked.contains(flag));
Logger.recordOutput(loggerCategory + "/Flags/" + flag.toString(), checked.contains(flag));
}
}

Expand All @@ -33,7 +33,7 @@ public void check(T flag) {
}

public List<T> getChecked() {
return new ArrayList<T>(checked);
return new ArrayList<>(checked);
}

public void clear() {
Expand Down

0 comments on commit 6e8cd9b

Please sign in to comment.