From c1cc7c81e6c092c3410b4e3e7b7891757226dd0e Mon Sep 17 00:00:00 2001 From: Jordan <117786700+jordanjcoderman@users.noreply.github.com> Date: Sat, 24 Feb 2024 12:29:51 -0800 Subject: [PATCH 1/3] changed lightsOnExit to run for 0.5 seconds --- src/main/java/frc/robot/lights/LightsSubsystem.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/frc/robot/lights/LightsSubsystem.java b/src/main/java/frc/robot/lights/LightsSubsystem.java index f922e335..606586ab 100644 --- a/src/main/java/frc/robot/lights/LightsSubsystem.java +++ b/src/main/java/frc/robot/lights/LightsSubsystem.java @@ -76,10 +76,10 @@ public void robotPeriodic() { lightsOnExit = Optional.of(previousState.lightsOnExit.get()); } - if (lightsOnExitTimer.hasElapsed(1.5)) { + if (lightsOnExitTimer.hasElapsed(0.5)) { lightsOnExit = Optional.empty(); - lightsOnExitTimer.reset(); lightsOnExitTimer.stop(); + lightsOnExitTimer.reset(); } if (lightsOnExit.isPresent()) { From 62ed6214b04957862e81a13d554bd582f809dd4d Mon Sep 17 00:00:00 2001 From: Jordan <117786700+jordanjcoderman@users.noreply.github.com> Date: Sat, 24 Feb 2024 12:33:51 -0800 Subject: [PATCH 2/3] fix limelight not turning off --- src/main/java/frc/robot/lights/LightsSubsystem.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/main/java/frc/robot/lights/LightsSubsystem.java b/src/main/java/frc/robot/lights/LightsSubsystem.java index 606586ab..b8c712e2 100644 --- a/src/main/java/frc/robot/lights/LightsSubsystem.java +++ b/src/main/java/frc/robot/lights/LightsSubsystem.java @@ -116,18 +116,16 @@ public void robotPeriodic() { blinkTimer.reset(); candle.setLEDs(0, 0, 0); - if (state.color() != Color.kWhite) { - LimelightHelpers.setLEDMode_ForceOff(""); - // do the limelight blinky stuff (turned off) - } } else if (time >= onDuration) { candle.setLEDs(color8Bit.red, color8Bit.green, color8Bit.blue); if (state.color() == Color.kWhite) { LimelightHelpers.setLEDMode_ForceBlink(""); - // do the limelight blinky stuff (turned on) + } + if (state.color() != Color.kWhite) { + LimelightHelpers.setLEDMode_ForceOff(""); } } } From f6f35429e81ce2df5fdc2d1d2e8c2e9f792528bb Mon Sep 17 00:00:00 2001 From: Jordan <117786700+jordanjcoderman@users.noreply.github.com> Date: Sat, 24 Feb 2024 12:35:38 -0800 Subject: [PATCH 3/3] Fix limelight blink --- .../java/frc/robot/lights/LightsSubsystem.java | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/main/java/frc/robot/lights/LightsSubsystem.java b/src/main/java/frc/robot/lights/LightsSubsystem.java index b8c712e2..ea1e5a7e 100644 --- a/src/main/java/frc/robot/lights/LightsSubsystem.java +++ b/src/main/java/frc/robot/lights/LightsSubsystem.java @@ -112,21 +112,17 @@ public void robotPeriodic() { offDuration = SLOW_BLINK_DURATION * 2; } + if (state.color() == Color.kWhite) { + LimelightHelpers.setLEDMode_ForceBlink(""); + } else { + LimelightHelpers.setLEDMode_ForceOff(""); + } + if (time >= offDuration) { blinkTimer.reset(); candle.setLEDs(0, 0, 0); - - - } else if (time >= onDuration) { candle.setLEDs(color8Bit.red, color8Bit.green, color8Bit.blue); - - if (state.color() == Color.kWhite) { - LimelightHelpers.setLEDMode_ForceBlink(""); - } - if (state.color() != Color.kWhite) { - LimelightHelpers.setLEDMode_ForceOff(""); - } } }