Could you add a sha1 checksum ? #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok for me, but exclude the node_modules from the commit, they shouldn't be inside the repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello leny !
A teacher of mine thought it would be great if we changed the hash function with another (he must be allergic to crc-32, I guess).
Anyway, I did it with a sha1 hash and it seems to work just fine. But I thought it would be better to expand your code than to replace it. Your tool would then be more useful.
So, I added the sha1 hash checksum to your crc-32 hash checksum instead of replacing it (I hope my teacher isn't actually allergic to crc-32, or else he's not going to like that).
So, just dropping the code here, just in case you consider using it in the future.
Hope it helps !