Skip to content

Commit 6a2e04a

Browse files
committed
Fixes #413, Fixes #371
1 parent 73db2e1 commit 6a2e04a

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

src/tech/v3/dataset/impl/dataset.clj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,9 @@
266266
;;select may be slower if we have to recalculate missing values.
267267
(lznc/map #(ds-proto/select-rows % rowidxs))
268268
(new-dataset (ds-proto/dataset-name dataset)
269-
(dissoc metadata :print-index-range)))))
269+
(if-not (identical? :all (get metadata :print-index-range))
270+
(dissoc metadata :print-index-range)
271+
metadata)))))
270272

271273

272274
ds-proto/PSelectColumns

test/tech/v3/dataset_test.clj

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1761,6 +1761,12 @@
17611761
:y (repeatedly 5 #(java.time.Instant/now))})]
17621762
(is (= 3 (count (into [] (take 3) (:y ds)))))))
17631763

1764+
1765+
(deftest issue-432-issue-371
1766+
(let [sds (ds/print-all (ds/->dataset {:x (repeatedly 50 rand)}))]
1767+
(is (= :all (:print-index-range (meta (ds/sort-by-column sds :x)))))
1768+
(is (= :all (:print-index-range (meta (ds/filter-column sds :x pos?)))))))
1769+
17641770
(comment
17651771
(require '[criterium.core :as crit])
17661772
(def data (vec (repeatedly 100000 (fn [] {:a (rand-int 20) :b (rand) :c (rand)}))))

0 commit comments

Comments
 (0)