Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rust category and a snippet #197

Merged

Conversation

sponkurtus2
Copy link
Contributor

Description

I added the Linux category for Rust, in case people need to add related Linux code, such as desktop enviroment, etc.

Type of Change

  • [✔️ ] ✨ New snippet
  • 🛠 Improvement to an existing snippet
  • 🐞 Bug fix
  • 📖 Documentation update
  • 🔧 Other (please describe):

Checklist

  • [✔️ ] I have tested my code and verified it works as expected.
  • [ ✔️] My code follows the style and contribution guidelines of this project.
  • [ ✔️] Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • [ ✔️] There are no new warnings or errors from my changes.

Related Issues

Closes #

Additional Context

Screenshots (Optional)

Click to view screenshots

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@majvax majvax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your contribution! 🙌

I had one question: shouldn’t you also check for the WAYLAND_DISPLAY environment variable? Since many modern Linux systems are moving to Wayland as a replacement for X11, it might be worth including this check.

@sponkurtus2
Copy link
Contributor Author

Hey, I think you are right, i'll implement it now and push the code, thank you for the tip :).

@sponkurtus2
Copy link
Contributor Author

Forget it, It is not necesary, since all the code is getting, is the desktop enviroment e.g. (gnome, xfce, i3), so we don't need to check the wayland_display.

@sponkurtus2 sponkurtus2 requested a review from majvax January 7, 2025 17:13
@Mathys-Gasnier
Copy link
Collaborator

Hey, before we move on, could you please merge main into your branch ? Making sure that /public/consolidated doesn't exist

@sponkurtus2
Copy link
Contributor Author

Is it right now?

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good

@Mathys-Gasnier Mathys-Gasnier merged commit 030861d into technoph1le:main Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants