Improve Language Selector dropdowns #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, there! Awesome work. Love it 👍 |
|
I just realised there is a small bug when using the keyboard navigation. The hidden - languages are also being selected since they are still part of the list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist
Related Issues
Additional Context
This is an improvement to LanguageSelector dropdown and the SubLanguage dropdown. I have added some animations to the dropdowns using vanilla CSS. I have removed showing the dropdown using the state variable and used it to just change the CSS class. As a side effect this then renders the dropdowns and fetches SVG icons the background which also removes the weird state where the dropdown has the icons missing on the initial load (Recreated by disabling cache). (Shown below in the videos)
Demonstrations
Old Dropdown
dropdown-old.mp4
New Dropdown
dropdown-new.mp4