You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For months, https://github.com/jenssegers/blade has been abandoned. Issues and PRs are not being taken care of, so we should get rid of that dependency.
There are a few options:
Fork the package with the required changes
Use illuminate/view with a custom bridge
Find another Blade package
Benefits
Every time we run some Tempest code that boots that package up, we get deprecation warnings:
Deprecated: Jenssegers\Blade\Blade::__construct(): Implicitly marking parameter $container as nullable is deprecated, the explicit nullable type must be used instead in /Users/enzoinnocenzi/Code/forks/tempest-framework/vendor/jenssegers/blade/src/Blade.php on line 34
This is particularly annoying in tests:
1 test triggered 1 PHP deprecation:
1) /Users/enzoinnocenzi/Code/forks/tempest-framework/vendor/jenssegers/blade/src/Blade.php:34
Jenssegers\Blade\Blade::__construct(): Implicitly marking parameter $container as nullable is deprecated, the explicit nullable type must be used instead
Triggered by:
* Tests\Tempest\Integration\Console\Components\TaskComponentTest::test_no_task
/Users/enzoinnocenzi/Code/forks/tempest-framework/tests/Integration/Console/Components/TaskComponentTest.php:38
OK, but there were issues!
Tests: 4, Assertions: 8, Deprecations: 1.
* Terminal will be reused by tasks, press any key to close it.
The text was updated successfully, but these errors were encountered:
Actually, looking at the source of jenssegers/blade, it should be pretty trivial to make our own bridge. In that case, I rather have our own package instead of forking the existing one, starting from a clean slate and including Tempest-specific stuff (initializer, blade config)
Description
For months, https://github.com/jenssegers/blade has been abandoned. Issues and PRs are not being taken care of, so we should get rid of that dependency.
There are a few options:
illuminate/view
with a custom bridgeBenefits
Every time we run some Tempest code that boots that package up, we get deprecation warnings:
This is particularly annoying in tests:
The text was updated successfully, but these errors were encountered: