Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(database): add UploadCaster class #775

Closed
wants to merge 19 commits into from

Conversation

yassiNebeL
Copy link
Contributor

Closes #723

@yassiNebeL yassiNebeL marked this pull request as ready for review November 25, 2024 18:54
@brendt
Copy link
Member

brendt commented Nov 26, 2024

Could you add a test?

@brendt brendt marked this pull request as draft November 26, 2024 07:24
@yassiNebeL
Copy link
Contributor Author

Could you add a test?

Yes.

@yassiNebeL
Copy link
Contributor Author

yassiNebeL commented Dec 2, 2024

Hi, We are in the process of persisting uploaded files, so we need to specify the storage path. Any ideas on how to achieve this? Should I use a constant or a property in the UploadCaster? In the database, I store only the filename. I checked the PathHelper class but didn’t find a related method for handling this scenario.

In the short, where do I need to move the uploaded file (location), because we need to move it within the UploadCaster class?

@yassiNebeL yassiNebeL closed this Dec 2, 2024
@yassiNebeL yassiNebeL deleted the feature/upload-caster branch December 3, 2024 23:13
@yassiNebeL yassiNebeL restored the feature/upload-caster branch December 8, 2024 02:37
@yassiNebeL yassiNebeL reopened this Dec 8, 2024
@brendt
Copy link
Member

brendt commented Dec 11, 2024

Gonne revisit this one after #843

@brendt brendt closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UploadCaster for Tempest\Http\Upload class
2 participants