Updating with upstream #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ConsumerServiceURL. p49 - https://www.oasis-open.org/committees/download.php/35711/sstc-saml-core-errata-2.0-wd-06-diff.pdf options.disableRequestACSUrl - default to undefined falsy so it is automatically included.
This add the ability to extract the original SamlResponseXML as a method in the profile object.
Either use cache provided by user, or a default memory cache to store InResponse parameters. This cache is not yet partitioned per provider, which means a malicious provider could do replay attacks by using anothers unconsummed `InResponse` values node-saml#334
This change incorporates a revert that fixes the problem discussed on node-saml/xml-crypto#167. It also drops xpath.js in favour of xpath, which everybody else uses. Fixes node-saml#324
This adds a function to pass in a request along with the other `generateServiceProviderMetadata` arguments to retrieve provider metadata when using the MultiSamlStrategy. If there is no request, we cannot call the `_getSamlOptions`-function to retrieve all the necessary options to call the `generateServiceProviderMetadata`-function with.
… element should be accessed only through ._
Some deps had warnings about being outdated.
Change attributeName to unknown type to allow for use-case described in DefinitelyTyped/DefinitelyTyped#33950. For example, you may extend the Profile object with an attribute `roles` which is an array of string. Having unknown still allows for typing enforcement, and yet is flexible to allow for these use-cases
test: add test for check the option comparisonType
- 'comparisonType' is too generic. - Also, document in the main README.
Merge branch 'master' into remove-inresponseto-if-response-validation-fails Update Update
Added a conditional statement to set NameIDFormat only if identifierFormat is specified in options. This should prevent an error in AD FS when identifierFormat set to null: node-saml#338
Before this commit: signature validation on GET (Redirect binding) requests was done using `encodeURIComponent` on the already parsed params After: the original query params are used to validate the request's signature The reason for doing this is that Azure ADFS is using lowercase for url encoding resulting in something like: `SAMLRequest=dead%2fbeef` The old processing logic would try to validate against: `SAMLRequest=dead%2Fbeef` and failed
Before we were using a more vague substring match and choosing the last possible match. Now we extract the algorithm name from the expected URL format and test for an exact match on the algorithm name, case-insensitive.
It has been EOL'ed.
- Fix also Travis to run eslint instead of jshint - Upgrade eslint dep - fix lint violations
Using the same rules as nodejs.
Note: self = this is needed and tests fail if using arrow function as suggested in the PR review.
* Fix minimum version of Node.js in Travis Support for Node 6 was dropped in dd1699a
Just modernizing the code some.
* fix node-saml#393 adding 'inResponseTo' in the profile
This update will pick up the following changes: node-saml/xml-crypto#171 node-saml/xml-crypto#179 node-saml/xml-crypto#183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.