Skip to content

Commit 94c6af2

Browse files
aktechaktech
committed
remove xfails that are passing
1 parent ec7c05b commit 94c6af2

17 files changed

+125
-86
lines changed

‎tensorflow_data_validation/api/stats_api_test.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class StatsAPITest(absltest.TestCase):
4444
def _get_temp_dir(self):
4545
return tempfile.mkdtemp()
4646

47-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
47+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
4848
def test_stats_pipeline(self):
4949
record_batches = [
5050
pa.RecordBatch.from_arrays([
@@ -203,7 +203,7 @@ def test_stats_pipeline(self):
203203
}
204204
""", statistics_pb2.DatasetFeatureStatisticsList())
205205

206-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
206+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
207207
def test_stats_pipeline_with_examples_with_no_values(self):
208208
record_batches = [
209209
pa.RecordBatch.from_arrays([
@@ -321,7 +321,7 @@ def test_stats_pipeline_with_examples_with_no_values(self):
321321
test_util.make_dataset_feature_stats_list_proto_equal_fn(
322322
self, expected_result, check_histograms=False))
323323

324-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
324+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
325325
def test_stats_pipeline_with_zero_examples(self):
326326
expected_result = text_format.Parse(
327327
"""
@@ -343,7 +343,7 @@ def test_stats_pipeline_with_zero_examples(self):
343343
test_util.make_dataset_feature_stats_list_proto_equal_fn(
344344
self, expected_result, check_histograms=False))
345345

346-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
346+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
347347
def test_stats_pipeline_with_sample_rate(self):
348348
record_batches = [
349349
pa.RecordBatch.from_arrays(
@@ -493,7 +493,7 @@ def test_write_stats_to_tfrecord_and_binary(self):
493493

494494
class MergeDatasetFeatureStatisticsListTest(absltest.TestCase):
495495

496-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
496+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
497497
def test_merges_two_shards(self):
498498
stats1 = text_format.Parse(
499499
"""

‎tensorflow_data_validation/api/validation_api_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3241,7 +3241,7 @@ def _assert_skew_pairs_equal(self, actual, expected) -> None:
32413241
for each in actual:
32423242
self.assertIn(each, expected)
32433243

3244-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
3244+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
32453245
def test_detect_feature_skew(self):
32463246
training_data = [
32473247
text_format.Parse("""

‎tensorflow_data_validation/coders/csv_decoder_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@
366366
]
367367

368368

369-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed. ")
369+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed. ")
370370
class CSVDecoderTest(parameterized.TestCase):
371371
"""Tests for CSV decoder."""
372372

‎tensorflow_data_validation/integration_tests/sequence_example_e2e_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1738,7 +1738,7 @@
17381738
]
17391739

17401740

1741-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed. ")
1741+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed. ")
17421742
class SequenceExampleStatsTest(parameterized.TestCase):
17431743

17441744
@classmethod

‎tensorflow_data_validation/skew/feature_skew_detector_test.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ def _make_ex(identifier: str,
142142

143143
class FeatureSkewDetectorTest(parameterized.TestCase):
144144

145-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
145+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
146146
def test_detect_feature_skew(self):
147147
baseline_examples, test_examples, _ = get_test_input(
148148
include_skewed_features=True, include_close_floats=True)
@@ -194,7 +194,7 @@ def test_detect_feature_skew(self):
194194
skew_result,
195195
test_util.make_skew_result_equal_fn(self, expected_result))
196196

197-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
197+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
198198
def test_detect_no_skew(self):
199199
baseline_examples, test_examples, _ = get_test_input(
200200
include_skewed_features=False, include_close_floats=False)
@@ -224,7 +224,7 @@ def test_detect_no_skew(self):
224224
util.assert_that(skew_sample, make_sample_equal_fn(self, 0, []),
225225
'CheckSkewSample')
226226

227-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
227+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
228228
def test_obtain_skew_sample(self):
229229
baseline_examples, test_examples, skew_pairs = get_test_input(
230230
include_skewed_features=True, include_close_floats=False)
@@ -248,7 +248,7 @@ def test_obtain_skew_sample(self):
248248
skew_sample, make_sample_equal_fn(self, sample_size,
249249
potential_samples))
250250

251-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
251+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
252252
def test_empty_inputs(self):
253253
baseline_examples, test_examples, _ = get_test_input(
254254
include_skewed_features=True, include_close_floats=True)
@@ -304,7 +304,7 @@ def test_empty_inputs(self):
304304
make_sample_equal_fn(self, 0, expected_result),
305305
'CheckSkewSample')
306306

307-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
307+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
308308
def test_float_precision_configuration(self):
309309
baseline_examples, test_examples, _ = get_test_input(
310310
include_skewed_features=True, include_close_floats=True)
@@ -395,7 +395,7 @@ def test_no_identifier_features(self):
395395
_ = ((baseline_examples, test_examples)
396396
| feature_skew_detector.DetectFeatureSkewImpl([]))
397397

398-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
398+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
399399
def test_duplicate_identifiers_allowed_with_duplicates(self):
400400
base_example_1 = text_format.Parse(
401401
"""
@@ -469,7 +469,7 @@ def test_duplicate_identifiers_allowed_with_duplicates(self):
469469
skew_result,
470470
test_util.make_skew_result_equal_fn(self, expected_result))
471471

472-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
472+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
473473
def test_duplicate_identifiers_not_allowed_with_duplicates(self):
474474
base_example_1 = text_format.Parse(
475475
"""
@@ -535,7 +535,7 @@ def test_duplicate_identifiers_not_allowed_with_duplicates(self):
535535
self.assertLen(actual_counter, 1)
536536
self.assertEqual(actual_counter[0].committed, 1)
537537

538-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
538+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
539539
def test_skips_missing_identifier_example(self):
540540
base_example_1 = text_format.Parse(
541541
"""
@@ -576,7 +576,7 @@ def test_skips_missing_identifier_example(self):
576576
runner = p.run()
577577
runner.wait_until_finish()
578578

579-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
579+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
580580
def test_empty_features_equivalent(self):
581581
base_example_1 = text_format.Parse(
582582
"""
@@ -626,7 +626,7 @@ def test_empty_features_equivalent(self):
626626
runner = p.run()
627627
runner.wait_until_finish()
628628

629-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
629+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
630630
def test_empty_features_not_equivalent_to_missing(self):
631631
base_example_1 = text_format.Parse(
632632
"""
@@ -699,7 +699,7 @@ def test_telemetry(self):
699699
self.assertLen(actual_counter, 1)
700700
self.assertEqual(actual_counter[0].committed, 1)
701701

702-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
702+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
703703
def test_confusion_analysis(self):
704704

705705
baseline_examples = [
@@ -834,7 +834,7 @@ def test_confusion_analysis_errors(self, input_example, expected_error_regex):
834834
feature_skew_detector.ConfusionConfig(name='val'),
835835
]))[feature_skew_detector.CONFUSION_KEY]
836836

837-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
837+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
838838
def test_match_stats(self):
839839
baseline_examples = [
840840
_make_ex('id0'),

‎tensorflow_data_validation/statistics/generators/lift_stats_generator_test.py

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ def test_lift_with_no_schema_or_x_path(self):
346346
lift_stats_generator.LiftStatsGenerator(
347347
schema=None, y_path=types.FeaturePath(['int_y']))
348348

349-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
349+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
350350
def test_lift_string_y(self):
351351
examples = [
352352
pa.RecordBatch.from_arrays([
@@ -454,7 +454,7 @@ def test_lift_string_y(self):
454454
add_default_slice_key_to_input=True,
455455
add_default_slice_key_to_output=True)
456456

457-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
457+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
458458
def test_lift_bytes_x_and_y(self):
459459
examples = [
460460
pa.RecordBatch.from_arrays([
@@ -530,7 +530,7 @@ def test_lift_bytes_x_and_y(self):
530530
add_default_slice_key_to_input=True,
531531
add_default_slice_key_to_output=True)
532532

533-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
533+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
534534
def test_lift_int_y(self):
535535
examples = [
536536
pa.RecordBatch.from_arrays([
@@ -697,7 +697,7 @@ def metrics_verify_fn(metric_results):
697697
add_default_slice_key_to_input=True,
698698
add_default_slice_key_to_output=True)
699699

700-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
700+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
701701
def test_lift_bool_y(self):
702702
examples = [
703703
pa.RecordBatch.from_arrays([
@@ -806,7 +806,7 @@ def test_lift_bool_y(self):
806806
add_default_slice_key_to_input=True,
807807
add_default_slice_key_to_output=True)
808808

809-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
809+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
810810
def test_lift_float_y(self):
811811
examples = [
812812
pa.RecordBatch.from_arrays([
@@ -952,7 +952,7 @@ def test_lift_float_y(self):
952952
add_default_slice_key_to_input=True,
953953
add_default_slice_key_to_output=True)
954954

955-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
955+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
956956
def test_lift_weighted(self):
957957
examples = [
958958
pa.RecordBatch.from_arrays([
@@ -1252,7 +1252,7 @@ def test_lift_weighted_weight_is_none(self):
12521252
with beam.Pipeline() as p:
12531253
_ = p | beam.Create(examples) | generator.ptransform
12541254

1255-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
1255+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
12561256
def test_lift_no_categorical_features(self):
12571257
examples = [
12581258
pa.RecordBatch.from_arrays([
@@ -1285,7 +1285,7 @@ def test_lift_no_categorical_features(self):
12851285
add_default_slice_key_to_input=True,
12861286
add_default_slice_key_to_output=True)
12871287

1288-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
1288+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
12891289
def test_lift_x_is_none(self):
12901290
examples = [
12911291
pa.RecordBatch.from_arrays([
@@ -1361,7 +1361,7 @@ def test_lift_x_is_none(self):
13611361
add_default_slice_key_to_input=True,
13621362
add_default_slice_key_to_output=True)
13631363

1364-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
1364+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
13651365
def test_lift_y_is_none(self):
13661366
examples = [
13671367
pa.RecordBatch.from_arrays([
@@ -1444,7 +1444,7 @@ def test_lift_y_is_none(self):
14441444
add_default_slice_key_to_input=True,
14451445
add_default_slice_key_to_output=True)
14461446

1447-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
1447+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
14481448
def test_lift_null_x(self):
14491449
examples = [
14501450
pa.RecordBatch.from_arrays([
@@ -1473,7 +1473,7 @@ def test_lift_null_x(self):
14731473
add_default_slice_key_to_input=True,
14741474
add_default_slice_key_to_output=True)
14751475

1476-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed. ")
1476+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed. ")
14771477
def test_lift_null_y(self):
14781478
examples = [
14791479
pa.RecordBatch.from_arrays([
@@ -1502,7 +1502,7 @@ def test_lift_null_y(self):
15021502
add_default_slice_key_to_input=True,
15031503
add_default_slice_key_to_output=True)
15041504

1505-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
1505+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
15061506
def test_lift_missing_x_and_y(self):
15071507
examples = [
15081508
pa.RecordBatch.from_arrays([
@@ -1532,7 +1532,7 @@ def test_lift_missing_x_and_y(self):
15321532
add_default_slice_key_to_input=True,
15331533
add_default_slice_key_to_output=True)
15341534

1535-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
1535+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
15361536
def test_lift_float_y_is_nan(self):
15371537
# after calling bin_array, this is effectively an empty array.
15381538
examples = [
@@ -1562,7 +1562,7 @@ def test_lift_float_y_is_nan(self):
15621562
add_default_slice_key_to_input=True,
15631563
add_default_slice_key_to_output=True)
15641564

1565-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
1565+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
15661566
def test_lift_min_x_count(self):
15671567
examples = [
15681568
pa.RecordBatch.from_arrays([
@@ -1628,7 +1628,7 @@ def test_lift_min_x_count(self):
16281628
add_default_slice_key_to_input=True,
16291629
add_default_slice_key_to_output=True)
16301630

1631-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
1631+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
16321632
def test_lift_min_x_count_filters_all(self):
16331633
examples = [
16341634
pa.RecordBatch.from_arrays([
@@ -1659,7 +1659,7 @@ def test_lift_min_x_count_filters_all(self):
16591659
add_default_slice_key_to_input=True,
16601660
add_default_slice_key_to_output=True)
16611661

1662-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
1662+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
16631663
def test_lift_overlapping_top_bottom_k(self):
16641664
examples = [
16651665
pa.RecordBatch.from_arrays([
@@ -1750,7 +1750,7 @@ def test_lift_overlapping_top_bottom_k(self):
17501750
add_default_slice_key_to_input=True,
17511751
add_default_slice_key_to_output=True)
17521752

1753-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
1753+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
17541754
def test_lift_flattened_x(self):
17551755
examples = [
17561756
pa.RecordBatch.from_arrays([
@@ -1854,7 +1854,7 @@ def test_lift_flattened_x(self):
18541854
add_default_slice_key_to_input=True,
18551855
add_default_slice_key_to_output=True)
18561856

1857-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
1857+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
18581858
def test_lift_flattened_x_leaf(self):
18591859
examples = [
18601860
pa.RecordBatch.from_arrays([
@@ -1930,7 +1930,7 @@ def test_lift_flattened_x_leaf(self):
19301930
add_default_slice_key_to_input=True,
19311931
add_default_slice_key_to_output=True)
19321932

1933-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
1933+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
19341934
def test_lift_multi_x(self):
19351935
examples = [
19361936
pa.RecordBatch.from_arrays([
@@ -2056,7 +2056,7 @@ def test_lift_multi_x(self):
20562056
add_default_slice_key_to_input=True,
20572057
add_default_slice_key_to_output=True)
20582058

2059-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
2059+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
20602060
def test_lift_provided_x_no_schema(self):
20612061
examples = [
20622062
pa.RecordBatch.from_arrays([
@@ -2123,7 +2123,7 @@ def test_lift_provided_x_no_schema(self):
21232123
add_default_slice_key_to_input=True,
21242124
add_default_slice_key_to_output=True)
21252125

2126-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed. ")
2126+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed. ")
21272127
def test_lift_flattened_x_and_y(self):
21282128
examples = [
21292129
pa.RecordBatch.from_arrays([
@@ -2242,7 +2242,7 @@ def test_lift_flattened_x_and_y(self):
22422242
add_default_slice_key_to_input=True,
22432243
add_default_slice_key_to_output=True)
22442244

2245-
@pytest.mark.xfail(run=False, reason="PR 260 This test fails and needs to be fixed.")
2245+
@pytest.mark.xfail(run=True, reason="PR 260 This test fails and needs to be fixed.")
22462246
def test_lift_slice_aware(self):
22472247
examples = [
22482248
('slice1', pa.RecordBatch.from_arrays([

0 commit comments

Comments
 (0)