Skip to content

Commit ec7c05b

Browse files
committed
use xfail instead of skip
1 parent 703684a commit ec7c05b

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

tensorflow_data_validation/api/validation_api_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3179,7 +3179,7 @@ def test_identify_anomalous_examples(self, examples, schema_text,
31793179
"test_identify_anomalous_examples_no_anomalies",
31803180
"test_identify_anomalous_examples_different_anomaly_reasons"
31813181
]:
3182-
pytest.skip("PR 260 This test fails and needs to be fixed.")
3182+
pytest.xfail(reason="PR 260 This test fails and needs to be fixed. ")
31833183

31843184
schema = text_format.Parse(schema_text, schema_pb2.Schema())
31853185
options = stats_options.StatsOptions(schema=schema)

tensorflow_data_validation/statistics/generators/mutual_information_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1533,7 +1533,7 @@ def test_ranklab_mi(self, column_partitions):
15331533
"test_ranklab_mi1",
15341534
"test_ranklab_mi2",
15351535
]:
1536-
pytest.skip("PR 260 This test fails and needs to be fixed.")
1536+
pytest.xfail(reason="PR 260 This test fails and needs to be fixed. ")
15371537
expected_result = [
15381538
_get_test_stats_with_mi([
15391539
types.FeaturePath(["fa"]),

tensorflow_data_validation/statistics/generators/partitioned_stats_generator_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ def test_sample_partition_combine(self, partitioned_record_batches, expected,
338338
"test_sample_partition_combine_empty_partition",
339339
"test_sample_partition_combine_partition_of_empty_rb",
340340
]:
341-
pytest.skip("PR 260 This test fails and needs to be fixed.")
341+
pytest.xfail(reason="PR 260 This test fails and needs to be fixed. ")
342342
np.random.seed(TEST_SEED)
343343
p = beam.Pipeline()
344344
result = (

tensorflow_data_validation/utils/feature_partition_util_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ def test_splits_statistics(
387387
"test_splits_statistics_many_partitions",
388388
"test_splits_statistics_two_partitions"
389389
]:
390-
pytest.skip("PR 260 This test fails and needs to be fixed.")
390+
pytest.xfail(reason="PR 260 This test fails and needs to be fixed. ")
391391
statistics = list(
392392
text_format.Parse(s, statistics_pb2.DatasetFeatureStatisticsList())
393393
for s in statistics)

0 commit comments

Comments
 (0)