Skip to content

Commit c3c62b8

Browse files
tomvdwThe TensorFlow Datasets Authors
authored and
The TensorFlow Datasets Authors
committed
When a BuilderConfig is given, then use the version from there
PiperOrigin-RevId: 696400814
1 parent 4aef4ae commit c3c62b8

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

tensorflow_datasets/core/dataset_builder.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1361,21 +1361,26 @@ def _create_builder_config(
13611361
if isinstance(builder_config, str):
13621362
if version is None and ":" in builder_config:
13631363
builder_config, version = builder_config.split(":")
1364+
elif version is None:
1365+
version = self.VERSION
13641366
config = self.get_builder_config(name=builder_config, version=version)
13651367
if config is not None:
13661368
return config
13671369
else:
13681370
close_matches = difflib.get_close_matches(
1369-
builder_config, self.builder_configs.keys(), n=10
1371+
f"{builder_config}:{version}",
1372+
[f"{bc.name}:{bc.version}" for bc in self.builder_configs.values()],
1373+
n=100,
13701374
)
1375+
close_matches = "\n".join(sorted(close_matches))
13711376
raise ValueError(
13721377
f"BuilderConfig {builder_config} not found with version {version}."
13731378
" Here are 10 BuilderConfigs whose name closely match:"
13741379
f" {close_matches}"
13751380
)
13761381

13771382
cls_builder_config = self.get_builder_config(
1378-
name=builder_config.name, version=version
1383+
name=builder_config.name, version=builder_config.version
13791384
)
13801385
if cls_builder_config is None:
13811386
logging.warning("Using custom data configuration: %s", builder_config)
@@ -1384,7 +1389,7 @@ def _create_builder_config(
13841389
raise ValueError(
13851390
"Cannot name a custom BuilderConfig the same as an available"
13861391
" BuilderConfig. Change the name.\n"
1387-
f"Requested: {builder_config}\n"
1392+
f"Requested: {builder_config}\n\n"
13881393
f"BuilderConfig in class: {cls_builder_config}"
13891394
)
13901395
else:

0 commit comments

Comments
 (0)