Skip to content

Croissant Builder does not allow partial versions without minor (e.g. {x.y}) #11047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stefanches7 opened this issue May 7, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@stefanches7
Copy link

/!\ PLEASE INCLUDE THE FULL STACKTRACE AND CODE SNIPPET

Short description
Invalid version '1.0'. Format should be x.y.z with {x,y,z} being numbers without leading zeros.
See mlcommons/croissant#861

Environment information

  • Operating System: win 11 pro

  • Python version: 3.12.9

  • tensorflow-datasets/tfds-nightly version: 4.9.8

  • tensorflow/tf-nightly version: 2.19.0

  • Does the issue still exists with the last `

tfds-nightly package (pip install --upgrade tfds-nightly`) ? yes

Reproduction instructions

export-dara.json

mport tensorflow_datasets as tfds
import mlcroissant as mlc


builder = tfds.dataset_builders.CroissantBuilder(
    jsonld="export-dara.json"
 )
builder.download_and_prepare()

If you share a colab, make sure to update the permissions to share it.

Link to logs

Image

Expected behavior
Not fail and accept 1.0

Additional context
See mlcommons/croissant#861

@ccl-core
Copy link
Collaborator

Thank you @stefanches7 for raising this issue, I sent #11053 to address this issue.

@ccl-core
Copy link
Collaborator

Hi @stefanches7 , the PR that should address this issue has been merged. It will be available in TFDS nightly starting from tomorrow (or the day after max). I'm closing this bug for now, please feel free to reopen it should the issue persist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants