Skip to content

Commit 90ea51a

Browse files
dhruvesh09jiyongjung
and
jiyongjung
authored
Fixes missing kfp_pod_name execution property in Kubeflow Pipelines. (#4157)
* Fixes missing kfp_pod_name execution property in Kubeflow Pipelines. Kubeflow Dag Runner should record additional execution property to store pod names. See also kubeflow/pipelines#6138. PiperOrigin-RevId: 391220221 Co-authored-by: jiyongjung <jiyongjung@google.com>
1 parent 2f54c36 commit 90ea51a

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

RELEASE.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222

2323
## Bug Fixes and Other Changes
2424

25+
* Fixed ths issue that kfp_pod_name is not generated as an execution property
26+
for Kubeflow Pipelines.
2527
* Fixed issue when InputValuePlaceholder is used as component parameter in
2628
container based component.
2729
* Depends on `kubernetes>=10.0.1,<13`

tfx/orchestration/kubeflow/container_entrypoint.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -416,6 +416,7 @@ def main():
416416
# `args.runtime_parameter` should become List[str] by using "append".
417417
parser.add_argument('--runtime_parameter', type=str, action='append')
418418

419+
# TODO(b/196892362): Replace hooking with a more straightforward mechanism.
419420
launcher._register_execution = _register_execution # pylint: disable=protected-access
420421

421422
args = parser.parse_args()

tfx/orchestration/portable/launcher.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -232,12 +232,8 @@ def _register_or_reuse_execution(
232232
'%s. Output artifacts may be overwritten.',
233233
execution.last_known_state)
234234
return execution
235-
return execution_publish_utils.register_execution(
236-
metadata_handler=metadata_handler,
237-
execution_type=execution_type,
238-
contexts=contexts,
239-
input_artifacts=input_artifacts,
240-
exec_properties=exec_properties)
235+
return _register_execution(metadata_handler, execution_type, contexts,
236+
input_artifacts, exec_properties)
241237

242238
def _prepare_execution(self) -> _ExecutionPreparationResult:
243239
"""Prepares inputs, outputs and execution properties for actual execution."""

0 commit comments

Comments
 (0)