Fix Ruff rule A

Author: smokestacklightnin

tfx/dsl/input_resolution/canned_resolver_functions.py

@@ -744,7 +744,7 @@ def pick(channel: channel_types.BaseChannel, i: int, /):
   return _slice(channel, start=i, stop=(i + 1) or None, min_count=1)
 
 
-def slice(  # noqa: A002
+def slice(  # noqa: A002, A001
     channel: channel_types.BaseChannel,
     /,
     start: Optional[int] = None,

tfx/dsl/input_resolution/ops/test_utils.py

@@ -54,7 +54,7 @@ class DummyArtifact(types.Artifact):
   # noqa: A002
   def __init__(
       self,
-      id: Optional[str] = None,
+      id: Optional[str] = None, # noqa: A001, A002
       uri: Optional[str] = None,
       create_time_since_epoch: Optional[int] = None,
   ):

tfx/dsl/io/fileio.py

@@ -33,7 +33,7 @@ def _get_filesystem(path) -> Type[filesystem.Filesystem]:
           .get_filesystem_for_path(path))
 
 
-def open(path: PathType, mode: str = 'r'):  # noqa: A002
+def open(path: PathType, mode: str = 'r'):  # noqa: A002, A001
   """Open a file at the given path."""
   return _get_filesystem(path).open(path, mode=mode)
 

tfx/dsl/placeholder/artifact_placeholder.py

@@ -23,7 +23,7 @@
 _types = placeholder_base.types
 
 
-def input(key: str) -> ArtifactPlaceholder:  # noqa: A002
+def input(key: str) -> ArtifactPlaceholder:  # noqa: A002, A001
   """Returns a Placeholder that represents an input artifact.
 
   Args:

tfx/orchestration/portable/input_resolution/mlmd_resolver/metadata_resolver.py

@@ -305,7 +305,7 @@ def get_downstream_artifacts_by_artifact_ids(
     if store is None:
       raise ValueError('MetadataStore provided to MetadataResolver is None.')
 
-    artifact_ids_str = ','.join(str(id) for id in artifact_ids)
+    artifact_ids_str = ','.join(str(id) for id in artifact_ids) # noqa: A001
     # If `max_num_hops` is set to 0, we don't need the graph traversal.
     if max_num_hops == 0:
       if not filter_query:
@@ -370,7 +370,7 @@ def get_downstream_artifacts_by_artifact_ids(
         candidate_artifact_ids.update(
             visited_ids[metadata_resolver_utils.NodeType.ARTIFACT]
         )
-      artifact_ids_str = ','.join(str(id) for id in candidate_artifact_ids)
+      artifact_ids_str = ','.join(str(id) for id in candidate_artifact_ids) # noqa: A001
       # Send a call to metadata_store to get filtered downstream artifacts.
       artifacts = store.get_artifacts(
           list_options=mlmd.ListOptions(
@@ -387,7 +387,7 @@ def get_downstream_artifacts_by_artifact_ids(
                 artifact_id_to_artifact[id],
                 artifact_type_by_id[artifact_id_to_artifact[id].type_id],
             )
-            for id in visited_ids[metadata_resolver_utils.NodeType.ARTIFACT]
+            for id in visited_ids[metadata_resolver_utils.NodeType.ARTIFACT] # noqa: A001
             if id in artifact_id_to_artifact
         ]
         if downstream_artifacts:
@@ -594,7 +594,7 @@ def get_upstream_artifacts_by_artifact_ids(
     if store is None:
       raise ValueError('MetadataStore provided to MetadataResolver is None.')
 
-    artifact_ids_str = ','.join(str(id) for id in artifact_ids)
+    artifact_ids_str = ','.join(str(id) for id in artifact_ids) # noqa: A001
     # If `max_num_hops` is set to 0, we don't need the graph traversal.
     if max_num_hops == 0:
       if not filter_query:
@@ -662,7 +662,7 @@ def get_upstream_artifacts_by_artifact_ids(
         candidate_artifact_ids.update(
             visited_ids[metadata_resolver_utils.NodeType.ARTIFACT]
         )
-      artifact_ids_str = ','.join(str(id) for id in candidate_artifact_ids)
+      artifact_ids_str = ','.join(str(id) for id in candidate_artifact_ids) # noqa: A001
       # Send a call to metadata_store to get filtered upstream artifacts.
       artifacts = store.get_artifacts(
           list_options=mlmd.ListOptions(
@@ -679,7 +679,7 @@ def get_upstream_artifacts_by_artifact_ids(
                 artifact_id_to_artifact[id],
                 artifact_type_by_id[artifact_id_to_artifact[id].type_id],
             )
-            for id in visited_ids[metadata_resolver_utils.NodeType.ARTIFACT]
+            for id in visited_ids[metadata_resolver_utils.NodeType.ARTIFACT] # noqa: A001
             if id in artifact_id_to_artifact
         ]
         if upstream_artifacts: