Skip to content

Commit a1bec7a

Browse files
authored
Merge pull request #1042 from tensorflow/revert-1041-kangminx/pd-ssd-01
Revert "Override boot-disk type and size for v5e node"
2 parents 9791eed + 0d2e612 commit a1bec7a

File tree

3 files changed

+8
-20
lines changed

3 files changed

+8
-20
lines changed

tools/kubernetes/terraform/examples/v5e/terraform.tfvars

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,31 +7,23 @@ tpu_node_pools = [{
77
machine_type = "ct5lp-hightpu-4t"
88
topology = "16x16"
99
policy = "sb-compact-1"
10-
disk_type = "pd-balanced"
11-
disk_size_gb = 50
1210
}, {
1311
zone = "us-east5-b"
1412
node_count = 64
1513
machine_type = "ct5lp-hightpu-4t"
1614
topology = "16x16"
1715
policy = "sb-compact-1"
18-
disk_type = "pd-balanced"
19-
disk_size_gb = 50
2016
}, {
2117
zone = "us-east5-b"
2218
node_count = 64
2319
machine_type = "ct5lp-hightpu-4t"
2420
topology = "16x16"
2521
policy = "sb-compact-1"
26-
disk_type = "pd-balanced"
27-
disk_size_gb = 50
2822
}, {
2923
zone = "us-east5-b"
3024
node_count = 64
3125
machine_type = "ct5lp-hightpu-4t"
3226
topology = "16x16"
3327
policy = "sb-compact-1"
34-
disk_type = "pd-balanced"
35-
disk_size_gb = 50
36-
}]
28+
}]
3729
maintenance_interval = "PERIODIC"

tools/kubernetes/terraform/module/main.tf

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ resource "google_container_cluster" "tpu_cluster" {
5858
release_channel {
5959
channel = "UNSPECIFIED"
6060
}
61-
61+
6262
network = google_compute_network.vpc.name
6363
subnetwork = google_compute_subnetwork.subnet.name
6464
logging_service = "logging.googleapis.com/kubernetes"
@@ -81,7 +81,7 @@ resource "google_container_node_pool" "multihost_tpu" {
8181
cluster = google_container_cluster.tpu_cluster.name
8282

8383
initial_node_count = var.tpu_node_pools[count.index].node_count
84-
84+
8585
management {
8686
auto_upgrade = false
8787
}
@@ -104,18 +104,16 @@ resource "google_container_node_pool" "multihost_tpu" {
104104
gcfs_config {
105105
enabled = true
106106
}
107-
108-
image_type = "COS_CONTAINERD"
107+
108+
image_type = "COS_CONTAINERD"
109109
machine_type = var.tpu_node_pools[count.index].machine_type
110-
disk_type = var.tpu_node_pools[count.index].disk_type
111-
disk_size_gb = var.tpu_node_pools[count.index].disk_size_gb
112110
tags = ["gke-node"]
113111
metadata = {
114112
disable-legacy-endpoints = "true"
115113
}
116114
}
117115
placement_policy {
118-
type = "COMPACT"
119-
policy_name = var.tpu_node_pools[count.index].policy
116+
type = "COMPACT"
117+
policy_name = var.tpu_node_pools[count.index].policy
120118
}
121119
}

tools/kubernetes/terraform/module/variables.tf

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,10 @@ variable "tpu_node_pools" {
3535
machine_type = string,
3636
topology = string,
3737
policy = string,
38-
disk_type = string,
39-
disk_size_gb = number,
4038
}))
4139
}
4240

4341
variable "maintenance_interval" {
44-
default = "AS_NEEDED"
42+
default = "AS_NEEDED"
4543
description = "maintenance interval for TPU machines."
4644
}

0 commit comments

Comments
 (0)