Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to r27 #2

Merged
merged 11 commits into from
Aug 15, 2024
Merged

Bump to r27 #2

merged 11 commits into from
Aug 15, 2024

Conversation

licy183
Copy link
Member

@licy183 licy183 commented Jul 25, 2024

No description provided.

@licy183 licy183 changed the title R27 Bump to r27 Jul 25, 2024
@Biswa96
Copy link
Member

Biswa96 commented Jul 26, 2024

I have tried to build r27 in my fork with all darwin and windows prebuilts removed. Build Toolchain job failed with out of disk space after running 4h 39m 54s.

I could try to shallow clone every project in manifest file. That may remove git version information (not the clang/llvm actual version). Is that ok for this project?

Also, do you build lldb? If not, lldb dependencies can be removed too.

@licy183
Copy link
Member Author

licy183 commented Jul 26, 2024

I could try to shallow clone every project in manifest file. That may remove git version information (not the clang/llvm actual version). Is that ok for this project?

IMO this will not work. During the build process, patches are applied according to the output of git rev-list --count HEAD, and shallow clone will obviously break it.

Also, do you build lldb? If not, lldb dependencies can be removed too.

I didn't compile lldb. I don't think that removing the source code of lldb's deps will help a lot anyway..

@Biswa96
Copy link
Member

Biswa96 commented Jul 26, 2024

During the build process, patches are applied according to the output of git rev-list --count HEAD, and shallow clone will obviously break it.

But the patches were applied correctly according to the logs. I have compared the logs between shallow clone and full history clone. I found similar patches are applied.

@licy183
Copy link
Member Author

licy183 commented Jul 27, 2024

But the patches were applied correctly according to the logs. I have compared the logs between shallow clone and full history clone. I found similar patches are applied.

I'm not sure about it. Maybe we can give it a try.

@licy183 licy183 merged commit 82c13ac into main Aug 15, 2024
5 checks passed
@licy183 licy183 deleted the r27 branch August 15, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants