Skip to content

feat: Support aws_dynamodb_resource_policy (closes #95) #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

drosin
Copy link
Contributor

@drosin drosin commented Feb 11, 2025

Description

The terraform module aws_dynamodb_resource_policy was added so that resource-based policies can be added to the DynamoDB table.

Motivation and Context

This new feature allows cross-account access of the DynamoDB table. It fixes the following issue: 95

Breaking Changes

This is not a breaking change.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects

I tested the code change as follows:

  • I deployed the example in the basic folder.
  • I created a new example to include a resource based policy in a new folder named examples/resource-based-policy based on the example in the basic folder. In the new example file, the placeholder account_id and role need to be exchanged for existing ones.
  • I have executed pre-commit run -a on my pull request

@drosin drosin changed the title feat: support aws_dynamodb_resource_policy (closes #95) Feat: support aws_dynamodb_resource_policy (closes #95) Feb 11, 2025
@drosin drosin changed the title Feat: support aws_dynamodb_resource_policy (closes #95) feat: Support aws_dynamodb_resource_policy (closes #95) Feb 11, 2025
drosin and others added 3 commits February 12, 2025 11:49
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
@drosin drosin requested a review from antonbabenko February 20, 2025 06:14
@drosin
Copy link
Contributor Author

drosin commented Mar 17, 2025

@antonbabenko, shall we merge the PR?

@antonbabenko antonbabenko merged commit eee22aa into terraform-aws-modules:master Mar 19, 2025
2 checks passed
antonbabenko pushed a commit that referenced this pull request Mar 19, 2025
## [4.3.0](v4.2.0...v4.3.0) (2025-03-19)

### Features

* Support `aws_dynamodb_resource_policy` (closes [#95](#95)) ([#96](#96)) ([eee22aa](eee22aa))
@antonbabenko
Copy link
Member

This PR is included in version 4.3.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants