-
-
Notifications
You must be signed in to change notification settings - Fork 186
feat: Support aws_dynamodb_resource_policy
(closes #95)
#96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
antonbabenko
merged 5 commits into
terraform-aws-modules:master
from
drosin:feature/95-support-resource-policy
Mar 19, 2025
Merged
feat: Support aws_dynamodb_resource_policy
(closes #95)
#96
antonbabenko
merged 5 commits into
terraform-aws-modules:master
from
drosin:feature/95-support-resource-policy
Mar 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws_dynamodb_resource_policy
(closes #95)
antonbabenko
requested changes
Feb 12, 2025
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
antonbabenko
requested changes
Feb 12, 2025
drosin
commented
Feb 13, 2025
@antonbabenko, shall we merge the PR? |
antonbabenko
approved these changes
Mar 19, 2025
This PR is included in version 4.3.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The terraform module aws_dynamodb_resource_policy was added so that resource-based policies can be added to the DynamoDB table.
Motivation and Context
This new feature allows cross-account access of the DynamoDB table. It fixes the following issue: 95
Breaking Changes
This is not a breaking change.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectsI tested the code change as follows:
pre-commit run -a
on my pull request