Skip to content

Commit 6197b1d

Browse files
rhenninghakamadare
authored andcommitted
Include env in resource names to avoid collisions (#12)
fixes #10
1 parent 52c417f commit 6197b1d

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

main.tf

+4-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ data "aws_vpc" "vpc" {
44

55
resource "aws_elasticache_replication_group" "redis" {
66
replication_group_id = "${format("%.20s","${var.name}-${var.env}")}"
7-
replication_group_description = "Terraform-managed ElastiCache replication group for ${var.name}-${data.aws_vpc.vpc.tags["Name"]}"
7+
replication_group_description = "Terraform-managed ElastiCache replication group for ${var.name}-${var.env}-${data.aws_vpc.vpc.tags["Name"]}"
88
number_cache_clusters = "${var.redis_clusters}"
99
node_type = "${var.redis_node_type}"
1010
automatic_failover_enabled = "${var.redis_failover}"
@@ -17,12 +17,12 @@ resource "aws_elasticache_replication_group" "redis" {
1717
}
1818

1919
resource "aws_elasticache_parameter_group" "redis_parameter_group" {
20-
name = "${replace(format("%.255s", lower(replace("tf-redis-${var.name}-${data.aws_vpc.vpc.tags["Name"]}", "_", "-"))), "/\\s/", "-")}"
21-
description = "Terraform-managed ElastiCache parameter group for ${var.name}-${data.aws_vpc.vpc.tags["Name"]}"
20+
name = "${replace(format("%.255s", lower(replace("tf-redis-${var.name}-${var.env}-${data.aws_vpc.vpc.tags["Name"]}", "_", "-"))), "/\\s/", "-")}"
21+
description = "Terraform-managed ElastiCache parameter group for ${var.name}-${var.env}-${data.aws_vpc.vpc.tags["Name"]}"
2222
family = "redis${replace(var.redis_version, "/\\.[\\d]+$/","")}" # Strip the patch version from redis_version var
2323
}
2424

2525
resource "aws_elasticache_subnet_group" "redis_subnet_group" {
26-
name = "${replace(format("%.255s", lower(replace("tf-redis-${var.name}-${data.aws_vpc.vpc.tags["Name"]}", "_", "-"))), "/\\s/", "-")}"
26+
name = "${replace(format("%.255s", lower(replace("tf-redis-${var.name}-${var.env}-${data.aws_vpc.vpc.tags["Name"]}", "_", "-"))), "/\\s/", "-")}"
2727
subnet_ids = ["${var.subnets}"]
2828
}

security_groups.tf

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
resource "aws_security_group" "redis_security_group" {
2-
name = "tf-sg-ec-${var.name}-${data.aws_vpc.vpc.tags["Name"]}"
3-
description = "Terraform-managed ElastiCache security group for ${var.name}-${data.aws_vpc.vpc.tags["Name"]}"
2+
name = "${format("%.255s", "tf-sg-ec-${var.name}-${var.env}-${data.aws_vpc.vpc.tags["Name"]}")}"
3+
description = "Terraform-managed ElastiCache security group for ${var.name}-${var.env}-${data.aws_vpc.vpc.tags["Name"]}"
44
vpc_id = "${data.aws_vpc.vpc.id}"
55

66
tags {
7-
Name = "tf-sg-ec-${var.name}-${data.aws_vpc.vpc.tags["Name"]}"
7+
Name = "tf-sg-ec-${var.name}-${var.env}-${data.aws_vpc.vpc.tags["Name"]}"
88
}
99
}
1010

0 commit comments

Comments
 (0)