Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature proposal: using tf_sg modules #5

Closed
ghost opened this issue Jun 27, 2017 · 1 comment
Closed

Feature proposal: using tf_sg modules #5

ghost opened this issue Jun 27, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 27, 2017

As long, as there exists a tf_aws_sg [1] module; there is no reason to maintain security_groups.tf separately. Security groups should be rewritten and we should use sg module.

@antonbabenko
Copy link
Member

Why would you want to make it as a dependency? This module is complete on its own, while it is completely possible to rely on other modules (like the one you mentioned) I don't think it is a good idea. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant