Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circle ci pipeline to validate the codes automatically #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ozbillwang
Copy link
Collaborator

@ozbillwang ozbillwang commented Aug 12, 2017

  • Add circle ci pipeline to validate the codes automatically
  • Did the same for tf_aws_ecs module
  • upgrade terraform version to 0.10.0
  • repository owner need to add this project in circle ci.

Successfully build at https://circleci.com/gh/BWITS/tf_aws_rds/2

@antonbabenko
Copy link
Member

Thanks for this code. I have applied it partially to VPC module some time ago, but disabled it because I am not sure how to reduce amount of copy-pastes of config.yml files between 10+ repositories.

Do you know if we can keep it outside (in a separate repository, for example), and include it dynamically when circleci triggers the workflow?

@brandonjbjelland
Copy link
Member

I've built out and run CI that is common across several similar projects in the past. This looks pretty similar. 😄

The approach we took was having a barebones common CI config file in each repo. All identical and very minimal. Within that, a git clone is made to another repo (the CI/CD automation repo) which houses the shared build, test, release, and notification code. This way, collaboration on the CI/CD portion can happen separately of the modules themselves and duplication is mostly avoided.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants