Skip to content

add : fully configurable version #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Mar 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
781c0a6
add : fully configurable version
Aayush-Abhyarthi Mar 5, 2025
1d9f1f9
Merge branch 'main' into baseline_DA
Aayush-Abhyarthi Mar 7, 2025
cf7ab9c
working code for fully-configurable variation
Aayush-Abhyarthi Mar 12, 2025
609490f
update variables
Aayush-Abhyarthi Mar 13, 2025
12d9433
SKIP UPGRADE TEST
Aayush-Abhyarthi Mar 13, 2025
5a56420
fix: cra scan
Aayush-Abhyarthi Mar 13, 2025
180ca17
fix: cra scan
Aayush-Abhyarthi Mar 13, 2025
6de6278
fix: cra scan
Aayush-Abhyarthi Mar 13, 2025
0968514
add: security-enforced variation
Aayush-Abhyarthi Mar 17, 2025
e4060bb
Merge branch 'main' into baseline_DA
Aayush-Abhyarthi Mar 17, 2025
5e87ae9
fix: tests
Aayush-Abhyarthi Mar 17, 2025
a34b815
resolve comments
Aayush-Abhyarthi Mar 19, 2025
81ccd0f
Merge branch 'main' into baseline_DA
Aayush-Abhyarthi Mar 19, 2025
db91381
Merge branch 'main' into baseline_DA
Aayush-Abhyarthi Mar 20, 2025
a6ee04f
fix: resolve comments
Aayush-Abhyarthi Mar 21, 2025
1610d86
fix: resolve comments
Aayush-Abhyarthi Mar 21, 2025
3d5c6de
fix: cra-scan
Aayush-Abhyarthi Mar 21, 2025
2d235ff
Merge branch 'main' into baseline_DA
Aayush-Abhyarthi Mar 24, 2025
a133332
resolve conflicts
Aayush-Abhyarthi Mar 24, 2025
0a31f19
fix: resolve comments
Aayush-Abhyarthi Mar 24, 2025
1208b06
resolve comments
Aayush-Abhyarthi Mar 25, 2025
1bea161
resolve conflicts
Aayush-Abhyarthi Mar 25, 2025
14d0c6a
resolve conflicts
Aayush-Abhyarthi Mar 26, 2025
8373ece
add tests
Aayush-Abhyarthi Mar 27, 2025
c3562ca
fix: error
Aayush-Abhyarthi Mar 27, 2025
02d9e06
resolve comments
Aayush-Abhyarthi Mar 27, 2025
ce59392
fix: resolve comments
Aayush-Abhyarthi Mar 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .catalog-onboard-pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,17 @@ offerings:
catalog_id: 7df1e4ca-d54c-4fd0-82ce-3d13247308cd
offering_id: 6d6ebc76-7bbd-42f5-8bc7-78f4fabd5944
variations:
- name: standard
- name: security-enforced
mark_ready: true
install_type: fullstack
scc:
instance_id: 1c7d5f78-9262-44c3-b779-b28fe4d88c37
region: us-south
scope_resource_group_var_name: existing_resource_group_name
- name: fully-configurable
mark_ready: true
install_type: fullstack
scc:
instance_id: 1c7d5f78-9262-44c3-b779-b28fe4d88c37
region: us-south
scope_resource_group_var_name: existing_resource_group_name
6 changes: 4 additions & 2 deletions cra-config.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
# More info about this file at https://github.com/terraform-ibm-modules/common-pipeline-assets/blob/main/.github/workflows/terraform-test-pipeline.md#cra-config-yaml
version: "v1"
CRA_TARGETS:
- CRA_TARGET: "solutions/standard" # Target directory for CRA scan. If not provided, the CRA Scan will not be run.
- CRA_TARGET: "solutions/fully-configurable" # Target directory for CRA scan. If not provided, the CRA Scan will not be run.
CRA_IGNORE_RULES_FILE: "cra-tf-validate-ignore-rules.json" # CRA Ignore file to use. If not provided, it checks the repo root directory for `cra-tf-validate-ignore-rules.json`
PROFILE_ID: "fe96bd4d-9b37-40f2-b39f-a62760e326a3" # SCC profile ID (currently set to 'IBM Cloud Framework for Financial Services' '1.7.0' profile).
CRA_ENVIRONMENT_VARIABLES: # An optional map of environment variables for CRA, where the key is the variable name and value is the value. Useful for providing TF_VARs.
TF_VAR_existing_kms_instance_crn: "crn:v1:bluemix:public:hs-crypto:us-south:a/abac0df06b644a9cabc6e44f55b3880e:e6dce284-e80f-46e1-a3c1-830f7adff7a9::"
TF_VAR_resource_group_name: "test"
TF_VAR_kms_encryption_enabled: "true"
TF_VAR_existing_resource_group_name: "geretain-test-secrets-manager"
TF_VAR_provider_visibility: "public"
TF_VAR_prefix: "test"
Loading