Call EnsureNoError after evaluating aws_route expression so unevaluable expressions are skipped (#320)

* Call EnsureNoError after evaluating an expression to ensure unevaluable expressions are skipped

* Catch another instance of EnsureNoError not being called

Author: jandersen-plaid

rules/aws_route_not_specified_target.go

@@ -66,13 +66,15 @@ func (r *AwsRouteNotSpecifiedTargetRule) Check(runner tflint.Runner) error {
 		for _, attribute := range resource.Body.Attributes {
 			var val cty.Value
 			err := runner.EvaluateExpr(attribute.Expr, &val, nil)
+			err = runner.EnsureNoError(err, func() error {
+				if val.IsNull() {
+					nullAttributes = nullAttributes + 1
+				}
+				return nil
+			})
 			if err != nil {
 				return err
 			}
-
-			if val.IsNull() {
-				nullAttributes = nullAttributes + 1
-			}
 		}
 
 		if len(resource.Body.Attributes)-nullAttributes == 0 {

rules/aws_route_specified_multiple_targets.go

@@ -66,13 +66,16 @@ func (r *AwsRouteSpecifiedMultipleTargetsRule) Check(runner tflint.Runner) error
 		for _, attribute := range resource.Body.Attributes {
 			var val cty.Value
 			err := runner.EvaluateExpr(attribute.Expr, &val, nil)
+			err = runner.EnsureNoError(err, func() error {
+				if val.IsNull() {
+					nullAttributes = nullAttributes + 1
+				}
+				return nil
+			})
 			if err != nil {
 				return err
 			}
 
-			if val.IsNull() {
-				nullAttributes = nullAttributes + 1
-			}
 		}
 
 		if len(resource.Body.Attributes)-nullAttributes > 1 {