Merge pull request #83 from wata727/refactoring_default_printer

Refactoring for default printer

Author: wata727

printer/checkstyle_test.go

@@ -1,9 +1,8 @@
 package printer
 
 import (
-	"testing"
-
 	"bytes"
+	"testing"
 
 	"github.com/wata727/tflint/issue"
 )

printer/default.go

@@ -22,24 +22,16 @@ func (p *Printer) DefaultPrint(issues []*issue.Issue) {
 	}
 
 	sort.Sort(issue.ByFile{Issues: issue.Issues(issues)})
-	bIssue := issues[0]
-	sIssues := []*issue.Issue{
-		issues[0],
-	}
+	issuesByFile := []*issue.Issue{}
 
-	for _, is := range issues[1:] {
-		if bIssue.File != is.File {
-			p.printByLine(sIssues)
-			sIssues = nil
+	for _, i := range issues {
+		if len(issuesByFile) != 0 && issuesByFile[len(issuesByFile)-1].File != i.File {
+			p.printByLine(issuesByFile)
+			issuesByFile = nil
 		}
-
-		sIssues = append(sIssues, is)
-		bIssue = is
+		issuesByFile = append(issuesByFile, i)
 	}
-	if sIssues != nil {
-		p.printByLine(sIssues)
-	}
-
+	p.printByLine(issuesByFile)
 	p.printSummary(issues)
 }
 

printer/default_test.go

@@ -1,3 +1,73 @@
 package printer
 
-// Nothing to do
+import (
+	"bytes"
+	"fmt"
+	"testing"
+
+	"github.com/wata727/tflint/issue"
+)
+
+func TestDefaultPrint(t *testing.T) {
+	cases := []struct {
+		Name   string
+		Input  []*issue.Issue
+		Result string
+	}{
+		{
+			Name:   "no issues",
+			Input:  []*issue.Issue{},
+			Result: successColor("Awesome! Your code is following the best practices :)") + "\n",
+		},
+		{
+			Name: "multi files",
+			Input: []*issue.Issue{
+				{
+					File:    "template.tf",
+					Line:    1,
+					Type:    "ERROR",
+					Message: "example error message",
+				},
+				{
+					File:    "application.tf",
+					Line:    10,
+					Type:    "NOTICE",
+					Message: "example notice message",
+				},
+				{
+					File:    "template.tf",
+					Line:    5,
+					Type:    "WARNING",
+					Message: "example warning message",
+				},
+				{
+					File:    "template.tf",
+					Line:    3,
+					Type:    "WARNING",
+					Message: "example warning message",
+				},
+			},
+			Result: fmt.Sprintf(`%s
+	%s example notice message
+%s
+	%s example error message
+	%s example warning message
+	%s example warning message
+
+Result: %s  (%s , %s , %s)
+`, fileColor("application.tf"), noticeColor("NOTICE:10"), fileColor("template.tf"), errorColor("ERROR:1"), warningColor("WARNING:3"), warningColor("WARNING:5"), fileColor("4 issues"), errorColor("1 errors"), warningColor("2 warnings"), noticeColor("1 notices")),
+		},
+	}
+
+	for _, tc := range cases {
+		stdout := &bytes.Buffer{}
+		stderr := &bytes.Buffer{}
+		p := NewPrinter(stdout, stderr)
+		p.DefaultPrint(tc.Input)
+		result := stdout.String()
+
+		if result != tc.Result {
+			t.Fatalf("\nBad: %s\nExpected: %s\n\ntestcase: %s", result, tc.Result, tc.Name)
+		}
+	}
+}