Merge pull request #81 from wata727/deprecated_aws_instance_not_specified_iam_profile

Add NOTE to aws_instance_not_specified_iam_profile

Author: wata727

README.md

@@ -57,7 +57,7 @@ Try running TFLint under the directory where Terraform is executed. It detect if
 ```
 $ tflint
 template.tf
-        NOTICE:1 "iam_instance_profile" is not specified. If you want to change it, you need to recreate it
+        NOTICE:1 "iam_instance_profile" is not specified. If you want to change it, you need to recreate instance. (Only less than Terraform 0.8.8)
         ERROR:3 "t1.2xlarge" is invalid instance type.
 
 Result: 2 issues  (1 errors , 0 warnings , 1 notices)

detector/aws_instance_not_specified_iam_profile.go

@@ -25,7 +25,7 @@ func (d *AwsInstanceNotSpecifiedIAMProfileDetector) Detect(file string, item *as
 	if IsKeyNotFound(item, "iam_instance_profile") {
 		issue := &issue.Issue{
 			Type:    d.IssueType,
-			Message: "\"iam_instance_profile\" is not specified. If you want to change it, you need to recreate it",
+			Message: "\"iam_instance_profile\" is not specified. If you want to change it, you need to recreate instance. (Only less than Terraform 0.8.8)",
 			Line:    item.Pos().Line,
 			File:    file,
 		}

detector/aws_instance_not_specified_iam_profile_test.go

@@ -24,7 +24,7 @@ resource "aws_instance" "web" {
 			Issues: []*issue.Issue{
 				&issue.Issue{
 					Type:    "NOTICE",
-					Message: "\"iam_instance_profile\" is not specified. If you want to change it, you need to recreate it",
+					Message: "\"iam_instance_profile\" is not specified. If you want to change it, you need to recreate instance. (Only less than Terraform 0.8.8)",
 					Line:    2,
 					File:    "test.tf",
 				},

docs/aws_instance_not_specified_iam_profile.md

@@ -18,7 +18,7 @@ The following is the execution result of TFLint:
 ```
 $ tflint
 template.tf
-        NOTICE:1 "iam_instance_profile" is not specified. If you want to change it, you need to recreate it
+        NOTICE:1 "iam_instance_profile" is not specified. If you want to change it, you need to recreate instance. (Only less than Terraform 0.8.8)
 
 Result: 1 issues  (0 errors , 0 warnings , 1 notices)
 ```
@@ -28,5 +28,7 @@ You can select only one IAM profile at instance setup. However, if you do not se
 
 Even if you think that you do not need an IAM profile, we recommend that you specify a dummy. Then you can change the privilege when you need it, so you can escape the recreate of the instance.
 
+NOTE: There is good news that Terraform 0.8.8 and later can change it later. However, it is better to give proper authority from the beginning. If you change it later, there is a possibility that your application may have unexpected effects.
+
 ## How To Fix
 Please add `iam_instance_profile` attribute.