Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-12705 | feat: Add min/max replica values to docs #860

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

den-rgb
Copy link

@den-rgb den-rgb commented Dec 6, 2024

What this PR does / why we need it:
Adding Min/Max info to machinepool replicas for classic and hcp clusters + max kubelet config pod pid limits
Which issue(s) this PR fixes OCM-12705

Change type

  • New feature
  • Bug fix
  • Build
  • CI
  • Documentation
  • Performance
  • Refactor
  • Style
  • Unit tests
  • Subsystem tests

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@davidleerh
Copy link

@den-rgb @gdbranco
After internal discussion it was deemed that listing the exact requirements within the TF docs and/or data source is not favored. It will be cumbersome to manage if any of these values get updated.
Instead it would be best if we link / provide URL to the official openshift document showing the requirements.

Copy link

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vkareh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@den-rgb den-rgb force-pushed the OCM-12705 branch 5 times, most recently from 6d1ad17 to 9a26111 Compare December 18, 2024 13:09
Copy link

openshift-ci bot commented Dec 18, 2024

@den-rgb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-presubmits-rosa-sts-advanced-critical-high-presubmit a7509ff link true /test e2e-presubmits-rosa-sts-advanced-critical-high-presubmit
ci/prow/e2e-presubmits-rosa-hcp-advanced-critical-high-presubmit a7509ff link true /test e2e-presubmits-rosa-hcp-advanced-critical-high-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants