Merge pull request #1838 from alixander/board-label-inherit

boards don't inherit label

Author: alixander

ci/release/changelogs/next.md

@@ -4,6 +4,8 @@
 
 #### Improvements 🧹
 
+- Boards no longer inherit `label` fields from parents. [#1838](https://github.com/terrastruct/d2/pull/1838)
+
 #### Bugfixes ⛑️
 
 - Fixes `null` being set on a nested shape not working in certain cases when connections also pointed to that shape [#1830](https://github.com/terrastruct/d2/pull/1830)

d2compiler/compile_test.go

@@ -2991,6 +2991,22 @@ steps: {
 				assert.True(t, g.IsFolderOnly)
 			},
 		},
+		{
+			name: "no-inherit-label",
+			run: func(t *testing.T) {
+				g, _ := assertCompile(t, `
+label: hi
+
+steps: {
+  1: {
+    RJ
+  }
+}
+`, "")
+				assert.True(t, g.Root.Label.MapKey != nil)
+				assert.True(t, g.Steps[0].Root.Label.MapKey == nil)
+			},
+		},
 		{
 			name: "scenarios_edge_index",
 			run: func(t *testing.T) {

d2ir/compile.go

@@ -361,6 +361,9 @@ func (c *compiler) overlay(base *Map, f *Field) {
 		return
 	}
 	base = base.CopyBase(f)
+	// Certain fields should never carry forward.
+	// If you give your scenario a label, you don't want all steps in a scenario to be labeled the same.
+	base.DeleteField("label")
 	OverlayMap(base, f.Map())
 	f.Composite = base
 }