Security level refactor, also GLOB.marine_main_ship is dead #17148
+477
−255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el, improved announcements, unhardcoded status display stuff, slightly less hardcoded fire alarm stuff, improved doc
github-actions
bot
added
Refactor
…ree in my head for days, so let me just...
TiviPlus
added
the
Refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Forgive me. Both for the potential code fuckups and the fact the first commit for this dates back to June 2024. It's another one of my refactors that I start and then don't PR for months.
On security levels
Security levels are now handled on a subsystem that reads subtypes of
/datum/security_level, instead of every security level being hardcoded into a big switch block. This is a port of TG's security level backend, essentially.Quite a bit can be changed about them by coders (or VV users). Flags exist for how it can be set by players, if it has delta alert traits (entails a state of emergency), and vars exist for some customization (announcement card colors, status display icons, fire alarm light colors, lowering/raising body and sound, config entries).
Signals are now used for any world objects that react to the sec level changing, instead of the previous implementation of doing all that in the proc where security level changing is handled.
GLOB.marine_main_shipis goneGLOB.marine_main_shipis dead, the vars it was holding are split into two GLOBAL_DATUMs (orbital_cannon and rail_gun) for our shipside fire support and a GLOBAL_VAR for emergency maints.Why It's Good For The Game
Hopefully better code.
Changelog
🆑
refactor: Refactored security levels and removed GLOB.marine_main_ship. Please report any weird behavior with security levels, or the systems affected by this removal (OB, railgun, maint all access, keycard authentication).
/:cl: