Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error wrapping in matrix-protection-suite-for-matrix-bot-sdk is broken somewhere leading to undecipherable errors when client-server calls fail #733

Open
Gnuxie opened this issue Feb 27, 2025 · 0 comments
Labels
2.0.0 Follow Up Issue discoverd in after the release of Draupnir 2.0.0 bug Something isn't working L2 Few Likelihood P3 Outrageous / Cannot continue to or start to use Priority level - includes missing documentation leading to same outrage etc T6 Crash Bug causes crash OR data loss

Comments

@Gnuxie
Copy link
Member

Gnuxie commented Feb 27, 2025

Context: https://matrix.to/#/%21IaWNErZAgQUhGqJXjX%3Amatrix.org/%24SNb3l3RFYT0qb7uxEUeIScDFwr5o4DExXLZ72fhQmlE?via=matrix.org&via=envs.net&via=ubuntu.com

INFO 18:29:05:464 [bridge] 100.96.3.55 - - [27/Feb/2025:18:29:05 +0000] "PUT /_matrix/app/v1/transactions/582086 HTTP/1.1" 200 2 "-" "Synapse/1.122.0"                                                               
Thu, 27 Feb 2025 18:29:05 GMT [INFO] [MPSInterfaceAdaptor] Command being processed for @mtrnord:midnightthoughts.space: admin allow @lexi:midnightthoughts.space                                                     
DEBUG 18:29:05:465 [MatrixHttpClient] (REQ-427) PUT https://matrix.draupnir.midnightthoughts.space/_matrix/client/v3/rooms/!jxncyHvQgKcmsHWwuC%3Adraupnir.midnightthoughts.space/state/m.policy.rule.user/Sp3v9mBCP6a
RKl1CJORIYUg6JHrFW%2FUV15d6iTerXho%3D                                                                                                                                                                                
ERROR 18:29:05:469 [MatrixHttpClient] (REQ-427)                                                                                                                                                                      
Thu, 27 Feb 2025 18:29:05 GMT [ERROR] [MPSInterfaceAdaptor] Caught an unexpcted error when attempting to process the command "admin allow @lexi:midnightthoughts.space" send by the user @mtrnord:midnightthoughts.sp
ace: TypeError: What on earth are you throwing exactly? because it isn't an error [object Object]                                                                                                                    
    at unknownError (/node_modules/matrix-protection-suite-for-matrix-bot-sdk/dist/Client/BotSDKBaseClient.js:38:11)                                                                                                 
    at resultifyBotSDKRequestError (/node_modules/matrix-protection-suite-for-matrix-bot-sdk/dist/Client/BotSDKBaseClient.js:75:9)                                                                                   
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)                                                                                                                                    
    at async BotSDKBaseClient.sendStateEvent (/node_modules/matrix-protection-suite-for-matrix-bot-sdk/dist/Client/BotSDKBaseClient.js:166:16)                                                                       
    at async StandardPolicyRoomEditor.createPolicy (/node_modules/matrix-protection-suite/dist/PolicyList/StandardPolicyRoomEditor.js:31:28)                                                                         
    at async AccessControl.allow (/draupnir/appservice/AccessControl.js:52:24)                                                                                                                                       
    at async Object.executor (/draupnir/appservice/bot/AccessCommands.js:17:16)                                                                                                                                      
    at async StandardCommandInvoker.invoke (/node_modules/@the-draupnir-project/interface-manager/dist/Adaptor/StandardCommandInvoker.js:24:20)                                                                      
    at async StandardMatrixInterfaceAdaptor.invoke (/node_modules/@the-draupnir-project/interface-manager/dist/MatrixInterfaceAdaptor/MatrixInterfaceAdaptor.js:27:31)                                               
    at async StandardMatrixInterfaceAdaptor.parseAndInvoke (/node_modules/@the-draupnir-project/interface-manager/dist/MatrixInterfaceAdaptor/MatrixInterfaceAdaptor.js:133:16)                                      
Thu, 27 Feb 2025 18:29:05 GMT [ERROR] [ActionException] ActionException Unknown a2fbfe02-9c68-4221-afed-c799c6a22ba7 What on earth are you throwing exactly? because it isn't an error [object Object] TypeError: Wha
t on earth are you throwing exactly? because it isn't an error [object Object]                                                                                                                                       
    at unknownError (/node_modules/matrix-protection-suite-for-matrix-bot-sdk/dist/Client/BotSDKBaseClient.js:38:11)                                                                                                 
    at resultifyBotSDKRequestError (/node_modules/matrix-protection-suite-for-matrix-bot-sdk/dist/Client/BotSDKBaseClient.js:75:9)                                                                                   
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)                                                                                                                                    
    at async BotSDKBaseClient.sendStateEvent (/node_modules/matrix-protection-suite-for-matrix-bot-sdk/dist/Client/BotSDKBaseClient.js:166:16)                                                                       
    at async StandardPolicyRoomEditor.createPolicy (/node_modules/matrix-protection-suite/dist/PolicyList/StandardPolicyRoomEditor.js:31:28)                                                                         
    at async AccessControl.allow (/draupnir/appservice/AccessControl.js:52:24)                                                                                                                                       
    at async Object.executor (/draupnir/appservice/bot/AccessCommands.js:17:16)                                                                                                                                      
    at async StandardCommandInvoker.invoke (/node_modules/@the-draupnir-project/interface-manager/dist/Adaptor/StandardCommandInvoker.js:24:20)                                                                      
    at async StandardMatrixInterfaceAdaptor.invoke (/node_modules/@the-draupnir-project/interface-manager/dist/MatrixInterfaceAdaptor/MatrixInterfaceAdaptor.js:27:31)                                               
    at async StandardMatrixInterfaceAdaptor.parseAndInvoke (/node_modules/@the-draupnir-project/interface-manager/dist/MatrixInterfaceAdaptor/MatrixInterfaceAdaptor.js:133:16)                                      
DEBUG 18:29:05:470 [MatrixHttpClient] (REQ-428) PUT https://matrix.draupnir.midnightthoughts.space/_matrix/client/v3/rooms/!jxncyHvQgKcmsHWwuC%3Adraupnir.midnightthoughts.space/send/m.reaction/1740680945470__inc3 
Thu, 27 Feb 2025 18:29:05 GMT [ERROR] [CommandException] a2fbfe02-9c68-4221-afed-c799c6a22ba7 What on earth are you throwing exactly? because it isn't an error [object Object] TypeError: What on earth are you thro
wing exactly? because it isn't an error [object Object]                                                                                                                                                              
    at unknownError (/node_modules/matrix-protection-suite-for-matrix-bot-sdk/dist/Client/BotSDKBaseClient.js:38:11)                                                                                                 
    at resultifyBotSDKRequestError (/node_modules/matrix-protection-suite-for-matrix-bot-sdk/dist/Client/BotSDKBaseClient.js:75:9)                                                                                   
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)                                                                                                                                    
    at async BotSDKBaseClient.sendStateEvent (/node_modules/matrix-protection-suite-for-matrix-bot-sdk/dist/Client/BotSDKBaseClient.js:166:16)                                                                       
    at async StandardPolicyRoomEditor.createPolicy (/node_modules/matrix-protection-suite/dist/PolicyList/StandardPolicyRoomEditor.js:31:28)                                                                         
    at async AccessControl.allow (/draupnir/appservice/AccessControl.js:52:24)                                                                                                                                       
    at async Object.executor (/draupnir/appservice/bot/AccessCommands.js:17:16)                                                                                                                                      
    at async StandardCommandInvoker.invoke (/node_modules/@the-draupnir-project/interface-manager/dist/Adaptor/StandardCommandInvoker.js:24:20)                                                                      
    at async StandardMatrixInterfaceAdaptor.invoke (/node_modules/@the-draupnir-project/interface-manager/dist/MatrixInterfaceAdaptor/MatrixInterfaceAdaptor.js:27:31)                                               
    at async StandardMatrixInterfaceAdaptor.parseAndInvoke (/node_modules/@the-draupnir-project/interface-manager/dist/MatrixInterfaceAdaptor/MatrixInterfaceAdaptor.js:133:16)                                      
DEBUG 18:29:05:471 [MatrixHttpClient] (REQ-429) PUT https://matrix.draupnir.midnightthoughts.space/_matrix/client/v3/rooms/!jxncyHvQgKcmsHWwuC%3Adraupnir.midnightthoughts.space/send/m.room.message/1740680945471__i
nc4                                                                                                                                                                                                                  
INFO 18:29:05:628 [bridge] 100.96.3.55 - - [27/Feb/2025:18:29:05 +0000] "PUT /_matrix/app/v1/transactions/582087 HTTP/1.1" 200 2 "-" "Synapse/1.122.0"
@Gnuxie Gnuxie added 2.0.0 Follow Up Issue discoverd in after the release of Draupnir 2.0.0 bug Something isn't working L2 Few Likelihood P3 Outrageous / Cannot continue to or start to use Priority level - includes missing documentation leading to same outrage etc T6 Crash Bug causes crash OR data loss labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.0 Follow Up Issue discoverd in after the release of Draupnir 2.0.0 bug Something isn't working L2 Few Likelihood P3 Outrageous / Cannot continue to or start to use Priority level - includes missing documentation leading to same outrage etc T6 Crash Bug causes crash OR data loss
Projects
Status: No status
Development

No branches or pull requests

1 participant