Skip to content

Admin Refresh - correct HTML Structure #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Apr 21, 2025

Conversation

redscar
Copy link
Contributor

@redscar redscar commented Apr 16, 2025

🎫 Ticket

🗒️ Description

Updated the HTML structure to stop using tec-settings-form__header-block--horizontal for every element. Instead updating the layout to match TEC settings better.

🎥 Artifacts

image
image
image
image
image
image
image
image
image
image

✔️ Checklist

  • Ran npm run changelog to add changelog file(s). More info here
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@redscar redscar added the code review Status: requires a code review. label Apr 16, 2025
@redscar redscar self-assigned this Apr 16, 2025
@redscar redscar marked this pull request as ready for review April 16, 2025 16:40
@redscar redscar changed the title Admin Refresh - Fixed missing closing divs. Admin Refresh - correct HTML Structure Apr 18, 2025
@redscar redscar merged commit a9423bc into bucket/admin-settings-refresh Apr 21, 2025
20 of 21 checks passed
@redscar redscar deleted the tweak/ET-2344_Email_Layouts branch April 21, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review Status: requires a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants