-
Notifications
You must be signed in to change notification settings - Fork 33
Migrate to WP Scripts for Building #2431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bordoni
wants to merge
88
commits into
master
Choose a base branch
from
bucket/packager
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a drop-in replacement for the `tribe_assets` function that will load assets from the `/build` directory.
Since assets are immediately registered in WordPress on registration, the URL will be set to the registration one. To avoid unregistering and re-registering the asset with the correct (/build) URL, just provide the `group_path` argument during registration.
…o bucket/packager
This updates the `data` attribute to use a less generic name and modifies the `click` handler logic to target IAN elements only. Additionally, ensure elements exist in the current context before targeting them.
…o bucket/packager
…o bucket/packager
Replace the WebPack configuration file with one set up by stellarwp/tyson. Together with it, remove the dependency on `product-taskmaster` including the babel configuration file.
Update the image paths from relative to the plugin root to relative to the postcss file being processed.
Explicitly require and include in the PostCSS pre-processing the `postcss-nested` and `postcss-custom-media` packages to make sure existing PostCSS code is processed the correct way, before `autoprefixer` kicks in.
Update the code to fix _most_ issues regarding asset registration and loading from the `/build` directory. Update the WebPack configuration file to include all required modules to build.
…path-in-tec_asset Consider group path in tec_asset function
Fix/tyson migration
Feat/linter and fixers
…wp-assets-1.4.7 Update stellarwp assets to 1.4.7
…rding-to-tec_asset Fix/tec assets according to tec asset
…log-objects Fix exposure of dialog objects
PR to update Action Scheduler version to match WooCommerce version has been created: #2501 |
…ict-resolution Bad merge conflict resolution
…fix/update-globals-for-linters [BOT] Update AS Version to match WC
…for-linters Update globals for linters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
TCMN-182
Please read more about this task here:
https://github.com/stellarwp/tyson/blob/main/docs/tec-migration.md