Fine-grained disable the block editor #2496
Conversation
The parent class already implements this as a no-op
| @@ -1,7 +1,6 @@ | |||
| <?php | |||
|
|
|||
| abstract class Tribe__Editor__Blocks__Abstract | |||
| implements Tribe__Editor__Blocks__Interface { | |||
| abstract class Tribe__Editor__Blocks__Abstract implements Tribe__Editor__Blocks__Interface { | |||
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶StellarWP.Classes.ValidClassName.NotSnakeCase
Class name "Tribe__Editor__Blocks__Abstract" is not in Capitalized_Snake_Case format
| @@ -1,7 +1,6 @@ | |||
| <?php | |||
|
|
|||
| abstract class Tribe__Editor__Blocks__Abstract | |||
| implements Tribe__Editor__Blocks__Interface { | |||
| abstract class Tribe__Editor__Blocks__Abstract implements Tribe__Editor__Blocks__Interface { | |||
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Squiz.Commenting.ClassComment.Missing
Missing doc comment for class Tribe__Editor__Blocks__Abstract
| @@ -1,7 +1,6 @@ | |||
| <?php | |||
|
|
|||
| abstract class Tribe__Editor__Blocks__Abstract | |||
| implements Tribe__Editor__Blocks__Interface { | |||
| abstract class Tribe__Editor__Blocks__Abstract implements Tribe__Editor__Blocks__Interface { | |||
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶PEAR.NamingConventions.ValidClassName.Invalid
Class name is not valid; consider Tribe_Editor_Blocks_Abstract instead
| @@ -54,12 +53,11 @@ | |||
| * | |||
| * @since 4.8 | |||
| * | |||
| * @param array $attributes | |||
| * @param array $attributes | |||
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Squiz.Commenting.FunctionComment.MissingParamComment
Missing parameter comment
| @@ -54,12 +53,11 @@ | |||
| * | |||
| * @since 4.8 | |||
| * | |||
| * @param array $attributes | |||
| * @param array $attributes | |||
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Squiz.Commenting.FunctionComment.ParamNameNoMatch
Doc comment for parameter $attributes does not match actual variable name $params
| } | ||
|
|
||
| /** | ||
| * Since we are dealing with a Dynamic type of Block we need a PHP method to render it | ||
| * | ||
| * @since 4.8 | ||
| * | ||
| * @param array $attributes | ||
| * @param array $attributes |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Squiz.Commenting.FunctionComment.MissingParamComment
Missing parameter comment
| @@ -174,10 +165,11 @@ | |||
| * the pattern of a block but not validating its structure. For strict accuracy | |||
| * you should use the block parser on post content. | |||
| * | |||
| * @since 4.8 | |||
| * @see gutenberg_parse_blocks() | |||
|
PR to update Action Scheduler version to match WooCommerce version has been created: #2514 |
🎫 Ticket
[TICKET_ID]
🗒️ Description
🎥 Artifacts
✔️ Checklist
npm run changelogto add changelog file(s). More info herewpunitorintegrationtests.wpunitorintegrationtests.